Skip to content

Removing unused struct mqttConnectionOptions #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2020
Merged

Removing unused struct mqttConnectionOptions #89

merged 1 commit into from
Feb 21, 2020

Conversation

aentinger
Copy link
Contributor

struct mqttConnectionOptions is not used within the code, the keep alive interval and connection timeout are instead directly set here.

mastrolinux
mastrolinux approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@mastrolinux mastrolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have seen it yesterday, was used before but now is stale code. Good you removed it!

@aentinger aentinger merged commit 380c433 into master Feb 21, 2020
@aentinger aentinger deleted the cleanup-unused-mqtt-connection-options branch February 21, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastrolinux mastrolinux mastrolinux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aentinger @mastrolinux