Skip to content

Removing deprecated update functions #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Removing deprecated update functions #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/ArduinoIoTCloud.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@ class ArduinoIoTCloudClass {
virtual bool disconnect() = 0;

virtual void update() = 0;
virtual void update(int const reconnectionMaxRetries, int const reconnectionTimeoutMs) __attribute__((deprecated)) = 0;
virtual void update(CallbackFunc onSyncCompleteCallback) __attribute__((deprecated)) = 0; /* Attention: Function is deprecated - use 'addCallback(ArduinoIoTCloudConnectionEvent::SYNC, &onSync)' for adding a onSyncCallback instead */

virtual int connected() = 0;

Expand Down
5 changes: 1 addition & 4 deletions src/ArduinoIoTCloudLPWAN.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ int ArduinoIoTCloudLPWAN::begin(LPWANConnectionHandler& connection, bool retry)
return 1;
}

void ArduinoIoTCloudLPWAN::update(CallbackFunc onSyncCompleteCallback) {
void ArduinoIoTCloudLPWAN::update() {
// Check if a primitive property wrapper is locally changed
Thing.updateTimestampOnLocallyChangedProperties();

Expand All @@ -82,9 +82,6 @@ void ArduinoIoTCloudLPWAN::update(CallbackFunc onSyncCompleteCallback) {
sendPropertiesToCloud();


if (onSyncCompleteCallback != NULL) {
(*onSyncCompleteCallback)();
}
execCloudEventCallback(_on_sync_event_callback, 0 /* callback_arg */);

}
Expand Down
8 changes: 1 addition & 7 deletions src/ArduinoIoTCloudLPWAN.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,7 @@ class ArduinoIoTCloudLPWAN : public ArduinoIoTCloudClass {
int connect();
bool disconnect();
int connected();
inline void update() {
update(NULL);
}
inline void update(int const reconnectionMaxRetries, int const reconnectionTimeoutMs) __attribute__((deprecated)) {
update(NULL);
}
void update(CallbackFunc onSyncCompleteCallback) __attribute__((deprecated));
void update();
void connectionCheck();
void printDebugInfo();
int begin(LPWANConnectionHandler& connection, bool retry = false);
Expand Down
5 changes: 1 addition & 4 deletions src/ArduinoIoTCloudTCP.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ bool ArduinoIoTCloudTCP::disconnect() {
return true;
}

void ArduinoIoTCloudTCP::update(CallbackFunc onSyncCompleteCallback) {
void ArduinoIoTCloudTCP::update() {
// Check if a primitive property wrapper is locally changed
Thing.updateTimestampOnLocallyChangedProperties();

Expand All @@ -245,9 +245,6 @@ void ArduinoIoTCloudTCP::update(CallbackFunc onSyncCompleteCallback) {
}
break;
case ArduinoIoTSynchronizationStatus::SYNC_STATUS_VALUES_PROCESSED: {
if (onSyncCompleteCallback != NULL) {
(*onSyncCompleteCallback)();
}
execCloudEventCallback(_on_sync_event_callback, 0 /* callback_arg */);
_syncStatus = ArduinoIoTSynchronizationStatus::SYNC_STATUS_SYNCHRONIZED;
}
Expand Down
8 changes: 1 addition & 7 deletions src/ArduinoIoTCloudTCP.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,7 @@ class ArduinoIoTCloudTCP: public ArduinoIoTCloudClass {
int connect();
bool disconnect();
int connected();
inline void update() {
update(NULL);
}
inline void update(int const reconnectionMaxRetries, int const reconnectionTimeoutMs) __attribute__((deprecated)) {
update(NULL);
}
void update(CallbackFunc onSyncCompleteCallback) __attribute__((deprecated));
void update();
void connectionCheck();
void printDebugInfo();
#ifdef BOARD_HAS_ECCX08
Expand Down