Skip to content

examples: remova LoRa from schedule example #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/workflows/compile-examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:
- examples/ArduinoIoTCloud-Advanced
- examples/ArduinoIoTCloud-Basic
- examples/ArduinoIoTCloud-Callbacks
- examples/ArduinoIoTCloud-Schedule
- examples/utility/ArduinoIoTCloud_Travis_CI
SKETCHES_REPORTS_PATH: sketches-reports

Expand Down Expand Up @@ -109,6 +108,7 @@ jobs:
- source-url: https://github.com/adafruit/Adafruit_SleepyDog.git
sketch-paths: |
- examples/ArduinoIoTCloud-Notecard
- examples/ArduinoIoTCloud-Schedule
- examples/utility/Provisioning
# MKR WiFi 1010, Nano 33 IoT, Nano RP2040 Connect
- board:
Expand All @@ -127,6 +127,7 @@ jobs:
sketch-paths: |
- examples/ArduinoIoTCloud-DeferredOTA
- examples/ArduinoIoTCloud-Notecard
- examples/ArduinoIoTCloud-Schedule
- examples/utility/Provisioning
- examples/utility/SelfProvisioning
- board:
Expand Down Expand Up @@ -156,6 +157,7 @@ jobs:
- source-url: https://github.com/adafruit/Adafruit_SleepyDog.git
sketch-paths: |
- examples/ArduinoIoTCloud-Notecard
- examples/ArduinoIoTCloud-Schedule
- examples/utility/Provisioning
# NB boards
- board:
Expand All @@ -171,6 +173,7 @@ jobs:
- source-url: https://github.com/adafruit/Adafruit_SleepyDog.git
sketch-paths: |
- examples/ArduinoIoTCloud-Notecard
- examples/ArduinoIoTCloud-Schedule
- examples/utility/Provisioning
# Portenta
- board:
Expand All @@ -185,6 +188,7 @@ jobs:
sketch-paths: |
- examples/ArduinoIoTCloud-DeferredOTA
- examples/ArduinoIoTCloud-Notecard
- examples/ArduinoIoTCloud-Schedule
- examples/utility/Provisioning
# Nicla Vision
- board:
Expand All @@ -197,6 +201,7 @@ jobs:
sketch-paths: |
- examples/ArduinoIoTCloud-DeferredOTA
- examples/ArduinoIoTCloud-Notecard
- examples/ArduinoIoTCloud-Schedule
- examples/utility/Provisioning
# Opta
- board:
Expand All @@ -210,6 +215,7 @@ jobs:
sketch-paths: |
- examples/ArduinoIoTCloud-DeferredOTA
- examples/ArduinoIoTCloud-Notecard
- examples/ArduinoIoTCloud-Schedule
- examples/utility/Provisioning
# GIGA
- board:
Expand All @@ -223,6 +229,7 @@ jobs:
sketch-paths: |
- examples/ArduinoIoTCloud-DeferredOTA
- examples/ArduinoIoTCloud-Notecard
- examples/ArduinoIoTCloud-Schedule
- examples/utility/Provisioning
# Portenta C33
- board:
Expand All @@ -235,6 +242,7 @@ jobs:
- name: Blues Wireless Notecard
sketch-paths: |
- examples/ArduinoIoTCloud-Notecard
- examples/ArduinoIoTCloud-Schedule
- examples/utility/Provisioning
# UNO R4 WiFi
- board:
Expand All @@ -246,6 +254,7 @@ jobs:
- name: Blues Wireless Notecard
sketch-paths: |
- examples/ArduinoIoTCloud-Notecard
- examples/ArduinoIoTCloud-Schedule
# Nano ESP32
- board:
type: arduino_esp32
Expand All @@ -257,6 +266,7 @@ jobs:
sketch-paths: |
- examples/ArduinoIoTCloud-DeferredOTA
- examples/ArduinoIoTCloud-Notecard
- examples/ArduinoIoTCloud-Schedule
# Edge Control
- board:
type: mbed_edge
Expand All @@ -267,6 +277,7 @@ jobs:
- name: Blues Wireless Notecard
sketch-paths: |
- examples/ArduinoIoTCloud-Notecard
- examples/ArduinoIoTCloud-Schedule
# ESP8266 boards
- board:
type: esp8266
Expand All @@ -277,7 +288,8 @@ jobs:
# Use the version currently installed in Arduino Cloud
version: 2.5.0
libraries:
sketch-paths:
sketch-paths: |
- examples/ArduinoIoTCloud-Schedule
# ESP32 boards
- board:
type: esp32
Expand All @@ -290,6 +302,7 @@ jobs:
sketch-paths: |
- examples/ArduinoIoTCloud-DeferredOTA
- examples/ArduinoIoTCloud-Notecard
- examples/ArduinoIoTCloud-Schedule

steps:
- name: Checkout
Expand Down
6 changes: 0 additions & 6 deletions examples/ArduinoIoTCloud-Schedule/arduino_secrets.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,6 @@
#define SECRET_PASS ""
#endif

/* MKR WAN 1300/1310 */
#if defined(BOARD_HAS_LORA)
#define SECRET_APP_EUI ""
#define SECRET_APP_KEY ""
#endif

/* Portenta H7 + Ethernet shield */
#if defined(BOARD_HAS_ETHERNET)
#define SECRET_OPTIONAL_IP ""
Expand Down
12 changes: 1 addition & 11 deletions examples/ArduinoIoTCloud-Schedule/thingProperties.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,14 @@
#include <Arduino_ConnectionHandler.h>
#include "arduino_secrets.h"

#if !(defined(HAS_TCP) || defined(HAS_LORA))
#if !defined(HAS_TCP)
#error "Please check Arduino IoT Cloud supported boards list: https://github.com/arduino-libraries/ArduinoIoTCloud/#what"
#endif

#if !defined(BOARD_HAS_SECURE_ELEMENT)
#define BOARD_ID "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
#endif

#if defined(HAS_LORA)
#define THING_ID "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
#endif

void onSwitchButtonChange();

bool switchButton;
Expand All @@ -40,19 +36,13 @@ void initProperties() {
ArduinoCloud.setBoardId(BOARD_ID);
ArduinoCloud.setSecretDeviceKey(SECRET_DEVICE_KEY);
#endif
#elif defined(HAS_LORA)
ArduinoCloud.addProperty(switchButton, 1, Permission::Write);

ArduinoCloud.setThingId(THING_ID);
#endif
}

#if defined(BOARD_HAS_WIFI)
WiFiConnectionHandler ArduinoIoTPreferredConnection(SECRET_WIFI_SSID, SECRET_WIFI_PASS);
#elif defined(BOARD_HAS_GSM)
GSMConnectionHandler ArduinoIoTPreferredConnection(SECRET_PIN, SECRET_APN, SECRET_LOGIN, SECRET_PASS);
#elif defined(BOARD_HAS_LORA)
LoRaConnectionHandler ArduinoIoTPreferredConnection(SECRET_APP_EUI, SECRET_APP_KEY, _lora_band::EU868, NULL, _lora_class::CLASS_A);
#elif defined(BOARD_HAS_NB)
NBConnectionHandler ArduinoIoTPreferredConnection(SECRET_PIN, SECRET_APN, SECRET_LOGIN, SECRET_PASS);
#elif defined(BOARD_HAS_CATM1_NBIOT)
Expand Down