Skip to content

Adding missing virtual destructor to Property #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andreagilardoni
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.39%. Comparing base (eddc451) to head (5d681e7).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #529   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files          33       33           
  Lines        1520     1521    +1     
=======================================
+ Hits         1450     1451    +1     
  Misses         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 5, 2025

Memory usage change @ 5d681e7

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 +152 - +284 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_edge:edge_control 🔺 +152 - +296 +0.02 - +0.03 0 - 0 0.0 - 0.0
arduino:mbed_giga:giga 🔺 0 - +304 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 0 - +272 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 🔺 0 - +304 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta 🔺 0 - +304 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 0 - +296 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:renesas_uno:unor4wifi 🔺 +104 - +280 +0.04 - +0.11 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 🔺 0 - +264 0.0 - +0.1 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 🔺 0 - +264 0.0 - +0.1 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 🔺 0 - +264 0.0 - +0.1 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 🔺 0 - +224 0.0 - +0.09 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 0 - +264 0.0 - +0.1 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 🔺 0 - +264 0.0 - +0.1 0 - 0 0.0 - 0.0
esp32:esp32:esp32 🔺 +148 - +316 +0.01 - +0.02 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah 🔺 +304 - +512 +0.03 - +0.05 0 - 0 0.0 - 0.0
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash
% examples/ArduinoIoTCloud-Advanced
RAM for global variables
% examples/ArduinoIoTCloud-Basic
flash
% examples/ArduinoIoTCloud-Basic
RAM for global variables
% examples/ArduinoIoTCloud-Callbacks
flash
% examples/ArduinoIoTCloud-Callbacks
RAM for global variables
% examples/ArduinoIoTCloud-Schedule
flash
% examples/ArduinoIoTCloud-Schedule
RAM for global variables
% examples/utility/ArduinoIoTCloud_Travis_CI
flash
% examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables
% examples/ArduinoIoTCloud-DeferredOTA
flash
% examples/ArduinoIoTCloud-DeferredOTA
RAM for global variables
% examples/ArduinoIoTCloud-Notecard
flash
% examples/ArduinoIoTCloud-Notecard
RAM for global variables
% examples/utility/Provisioning
flash
% examples/utility/Provisioning
RAM for global variables
% examples/utility/SelfProvisioning
flash
% examples/utility/SelfProvisioning
RAM for global variables
%
arduino:esp32:nano_nora 272 0.01 0 0.0 164 0.01 0 0.0 152 0.0 0 0.0 228 0.01 0 0.0 284 0.01 0 0.0 196 0.01 0 0.0 196 0.01 0 0.0
arduino:mbed_edge:edge_control 240 0.02 0 0.0 160 0.02 0 0.0 152 0.02 0 0.0 168 0.02 0 0.0 296 0.03 0 0.0 160 0.02 0 0.0
arduino:mbed_giga:giga 240 0.01 0 0.0 224 0.01 0 0.0 152 0.01 0 0.0 232 0.01 0 0.0 304 0.02 0 0.0 224 0.01 0 0.0 160 0.01 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 208 0.0 0 0.0 152 0.0 0 0.0 104 0.0 0 0.0 180 0.0 0 0.0 272 0.0 0 0.0 152 0.0 0 0.0 152 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 240 0.01 0 0.0 160 0.01 0 0.0 152 0.01 0 0.0 232 0.01 0 0.0 304 0.02 0 0.0 224 0.01 0 0.0 160 0.01 0 0.0 0 0.0 0 0.0
arduino:mbed_opta:opta 240 0.01 0 0.0 160 0.01 0 0.0 152 0.01 0 0.0 232 0.01 0 0.0 304 0.02 0 0.0 224 0.01 0 0.0 224 0.01 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 256 0.01 0 0.0 168 0.01 0 0.0 104 0.0 0 0.0 192 0.01 0 0.0 296 0.01 0 0.0 160 0.01 0 0.0 0 0.0 0 0.0
arduino:renesas_uno:unor4wifi 256 0.1 0 0.0 152 0.06 0 0.0 104 0.04 0 0.0 200 0.08 0 0.0 280 0.11 0 0.0 160 0.06 0 0.0
arduino:samd:mkr1000 208 0.08 0 0.0 152 0.06 0 0.0 104 0.04 0 0.0 176 0.07 0 0.0 264 0.1 0 0.0 152 0.06 0 0.0 0 0.0 0 0.0
arduino:samd:mkrgsm1400 208 0.08 0 0.0 152 0.06 0 0.0 104 0.04 0 0.0 176 0.07 0 0.0 264 0.1 0 0.0 152 0.06 0 0.0 0 0.0 0 0.0
arduino:samd:mkrnb1500 208 0.08 0 0.0 152 0.06 0 0.0 104 0.04 0 0.0 176 0.07 0 0.0 264 0.1 0 0.0 152 0.06 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1300 112 0.04 0 0.0 104 0.04 0 0.0 0 0.0 0 0.0 80 0.03 0 0.0 224 0.09 0 0.0 152 0.06 0 0.0
arduino:samd:mkrwifi1010 208 0.08 0 0.0 152 0.06 0 0.0 96 0.04 0 0.0 176 0.07 0 0.0 264 0.1 0 0.0 152 0.06 0 0.0 152 0.06 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot 208 0.08 0 0.0 152 0.06 0 0.0 96 0.04 0 0.0 176 0.07 0 0.0 264 0.1 0 0.0 152 0.06 0 0.0 152 0.06 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 300 0.02 0 0.0 216 0.02 0 0.0 148 0.01 0 0.0 272 0.02 0 0.0 316 0.02 0 0.0 216 0.02 0 0.0 192 0.01 0 0.0
esp8266:esp8266:huzzah 480 0.05 0 0.0 368 0.04 0 0.0 304 0.03 0 0.0 400 0.04 0 0.0 512 0.05 0 0.0
Click for full report CSV
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/ArduinoIoTCloud-Callbacks<br>flash,%,examples/ArduinoIoTCloud-Callbacks<br>RAM for global variables,%,examples/ArduinoIoTCloud-Schedule<br>flash,%,examples/ArduinoIoTCloud-Schedule<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/ArduinoIoTCloud-DeferredOTA<br>flash,%,examples/ArduinoIoTCloud-DeferredOTA<br>RAM for global variables,%,examples/ArduinoIoTCloud-Notecard<br>flash,%,examples/ArduinoIoTCloud-Notecard<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:esp32:nano_nora,272,0.01,0,0.0,164,0.01,0,0.0,152,0.0,0,0.0,228,0.01,0,0.0,284,0.01,0,0.0,196,0.01,0,0.0,196,0.01,0,0.0
arduino:mbed_edge:edge_control,240,0.02,0,0.0,160,0.02,0,0.0,152,0.02,0,0.0,168,0.02,0,0.0,296,0.03,0,0.0,,,,,160,0.02,0,0.0
arduino:mbed_giga:giga,240,0.01,0,0.0,224,0.01,0,0.0,152,0.01,0,0.0,232,0.01,0,0.0,304,0.02,0,0.0,224,0.01,0,0.0,160,0.01,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,208,0.0,0,0.0,152,0.0,0,0.0,104,0.0,0,0.0,180,0.0,0,0.0,272,0.0,0,0.0,152,0.0,0,0.0,152,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,240,0.01,0,0.0,160,0.01,0,0.0,152,0.01,0,0.0,232,0.01,0,0.0,304,0.02,0,0.0,224,0.01,0,0.0,160,0.01,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_opta:opta,240,0.01,0,0.0,160,0.01,0,0.0,152,0.01,0,0.0,232,0.01,0,0.0,304,0.02,0,0.0,224,0.01,0,0.0,224,0.01,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,
arduino:renesas_portenta:portenta_c33,256,0.01,0,0.0,168,0.01,0,0.0,104,0.0,0,0.0,192,0.01,0,0.0,296,0.01,0,0.0,,,,,160,0.01,0,0.0,0,0.0,0,0.0,,,,
arduino:renesas_uno:unor4wifi,256,0.1,0,0.0,152,0.06,0,0.0,104,0.04,0,0.0,200,0.08,0,0.0,280,0.11,0,0.0,,,,,160,0.06,0,0.0,,,,,,,,
arduino:samd:mkr1000,208,0.08,0,0.0,152,0.06,0,0.0,104,0.04,0,0.0,176,0.07,0,0.0,264,0.1,0,0.0,,,,,152,0.06,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,208,0.08,0,0.0,152,0.06,0,0.0,104,0.04,0,0.0,176,0.07,0,0.0,264,0.1,0,0.0,,,,,152,0.06,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,208,0.08,0,0.0,152,0.06,0,0.0,104,0.04,0,0.0,176,0.07,0,0.0,264,0.1,0,0.0,,,,,152,0.06,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,112,0.04,0,0.0,104,0.04,0,0.0,0,0.0,0,0.0,80,0.03,0,0.0,224,0.09,0,0.0,,,,,152,0.06,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,208,0.08,0,0.0,152,0.06,0,0.0,96,0.04,0,0.0,176,0.07,0,0.0,264,0.1,0,0.0,152,0.06,0,0.0,152,0.06,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,208,0.08,0,0.0,152,0.06,0,0.0,96,0.04,0,0.0,176,0.07,0,0.0,264,0.1,0,0.0,152,0.06,0,0.0,152,0.06,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,300,0.02,0,0.0,216,0.02,0,0.0,148,0.01,0,0.0,272,0.02,0,0.0,316,0.02,0,0.0,216,0.02,0,0.0,192,0.01,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,480,0.05,0,0.0,368,0.04,0,0.0,304,0.03,0,0.0,400,0.04,0,0.0,512,0.05,0,0.0,,,,,,,,,,,,,,,,

@andreagilardoni andreagilardoni merged commit 2c59002 into arduino-libraries:master Feb 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants