Skip to content

Debug: print mqttClient error code when connection fails #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2024

Conversation

pennam
Copy link
Collaborator

@pennam pennam commented May 16, 2024

It can provide useful feedback on why connection fails:

#define MQTT_CONNECTION_REFUSED            -2
#define MQTT_CONNECTION_TIMEOUT            -1
#define MQTT_SUCCESS                        0
#define MQTT_UNACCEPTABLE_PROTOCOL_VERSION  1
#define MQTT_IDENTIFIER_REJECTED            2
#define MQTT_SERVER_UNAVAILABLE             3
#define MQTT_BAD_USER_NAME_OR_PASSWORD      4
#define MQTT_NOT_AUTHORIZED                 5

@pennam pennam requested a review from andreagilardoni May 16, 2024 09:31
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (502590b) to head (20dd328).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files          27       27           
  Lines        1231     1231           
=======================================
  Hits         1170     1170           
  Misses         61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Memory usage change @ 20dd328

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 +36 - +56 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_edge:edge_control 🔺 +8 - +16 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_giga:giga 🔺 0 - +72 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 0 - +30 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 🔺 0 - +80 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta 🔺 0 - +80 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 0 - +24 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:renesas_uno:unor4wifi 🔺 +24 - +24 +0.01 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 🔺 0 - +32 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 🔺 0 - +32 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 🔺 0 - +32 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 0 - +40 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 🔺 0 - +40 0.0 - +0.02 0 - 0 0.0 - 0.0
esp32:esp32:esp32 🔺 +40 - +56 0.0 - 0.0 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah 🔺 +40 - +44 0.0 - 0.0 🔺 0 - +20 0.0 - +0.02
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash
% examples/ArduinoIoTCloud-Advanced
RAM for global variables
% examples/ArduinoIoTCloud-Basic
flash
% examples/ArduinoIoTCloud-Basic
RAM for global variables
% examples/ArduinoIoTCloud-Callbacks
flash
% examples/ArduinoIoTCloud-Callbacks
RAM for global variables
% examples/ArduinoIoTCloud-Schedule
flash
% examples/ArduinoIoTCloud-Schedule
RAM for global variables
% examples/utility/ArduinoIoTCloud_Travis_CI
flash
% examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables
% examples/ArduinoIoTCloud-DeferredOTA
flash
% examples/ArduinoIoTCloud-DeferredOTA
RAM for global variables
% examples/utility/Provisioning
flash
% examples/utility/Provisioning
RAM for global variables
% examples/utility/SelfProvisioning
flash
% examples/utility/SelfProvisioning
RAM for global variables
%
arduino:esp32:nano_nora 52 0.0 0 0.0 56 0.0 0 0.0 40 0.0 0 0.0 36 0.0 0 0.0 36 0.0 0 0.0 40 0.0 0 0.0
arduino:mbed_edge:edge_control 8 0.0 0 0.0 8 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0
arduino:mbed_giga:giga 8 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0 8 0.0 0 0.0 72 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 30 0.0 0 0.0 30 0.0 0 0.0 30 0.0 0 0.0 30 0.0 0 0.0 30 0.0 0 0.0 30 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 16 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 80 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_opta:opta 16 0.0 0 0.0 16 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 16 0.0 0 0.0 80 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 24 0.0 0 0.0 24 0.0 0 0.0 24 0.0 0 0.0 24 0.0 0 0.0 24 0.0 0 0.0 0 0.0 0 0.0
arduino:renesas_uno:unor4wifi 24 0.01 0 0.0 24 0.01 0 0.0 24 0.01 0 0.0 24 0.01 0 0.0 24 0.01 0 0.0
arduino:samd:mkr1000 32 0.01 0 0.0 32 0.01 0 0.0 32 0.01 0 0.0 32 0.01 0 0.0 32 0.01 0 0.0 0 0.0 0 0.0
arduino:samd:mkrgsm1400 32 0.01 0 0.0 32 0.01 0 0.0 32 0.01 0 0.0 32 0.01 0 0.0 32 0.01 0 0.0 0 0.0 0 0.0
arduino:samd:mkrnb1500 32 0.01 0 0.0 32 0.01 0 0.0 32 0.01 0 0.0 32 0.01 0 0.0 32 0.01 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 32 0.01 0 0.0 32 0.01 0 0.0 40 0.02 0 0.0 32 0.01 0 0.0 40 0.02 0 0.0 40 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot 32 0.01 0 0.0 32 0.01 0 0.0 40 0.02 0 0.0 32 0.01 0 0.0 40 0.02 0 0.0 40 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 56 0.0 0 0.0 52 0.0 0 0.0 52 0.0 0 0.0 52 0.0 0 0.0 40 0.0 0 0.0 52 0.0 0 0.0
esp8266:esp8266:huzzah 40 0.0 0 0.0 44 0.0 12 0.01 44 0.0 20 0.02 40 0.0 0 0.0 44 0.0 4 0.0
Click for full report CSV
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/ArduinoIoTCloud-Callbacks<br>flash,%,examples/ArduinoIoTCloud-Callbacks<br>RAM for global variables,%,examples/ArduinoIoTCloud-Schedule<br>flash,%,examples/ArduinoIoTCloud-Schedule<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/ArduinoIoTCloud-DeferredOTA<br>flash,%,examples/ArduinoIoTCloud-DeferredOTA<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:esp32:nano_nora,52,0.0,0,0.0,56,0.0,0,0.0,40,0.0,0,0.0,36,0.0,0,0.0,36,0.0,0,0.0,40,0.0,0,0.0
arduino:mbed_edge:edge_control,8,0.0,0,0.0,8,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,,,,
arduino:mbed_giga:giga,8,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,8,0.0,0,0.0,72,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,30,0.0,0,0.0,30,0.0,0,0.0,30,0.0,0,0.0,30,0.0,0,0.0,30,0.0,0,0.0,30,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,16,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,80,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_opta:opta,16,0.0,0,0.0,16,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,16,0.0,0,0.0,80,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,
arduino:renesas_portenta:portenta_c33,24,0.0,0,0.0,24,0.0,0,0.0,24,0.0,0,0.0,24,0.0,0,0.0,24,0.0,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:renesas_uno:unor4wifi,24,0.01,0,0.0,24,0.01,0,0.0,24,0.01,0,0.0,24,0.01,0,0.0,24,0.01,0,0.0,,,,,,,,,,,,
arduino:samd:mkr1000,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,,,,,
arduino:samd:mkrwifi1010,32,0.01,0,0.0,32,0.01,0,0.0,40,0.02,0,0.0,32,0.01,0,0.0,40,0.02,0,0.0,40,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,32,0.01,0,0.0,32,0.01,0,0.0,40,0.02,0,0.0,32,0.01,0,0.0,40,0.02,0,0.0,40,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,56,0.0,0,0.0,52,0.0,0,0.0,52,0.0,0,0.0,52,0.0,0,0.0,40,0.0,0,0.0,52,0.0,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,40,0.0,0,0.0,44,0.0,12,0.01,44,0.0,20,0.02,40,0.0,0,0.0,44,0.0,4,0.0,,,,,,,,,,,,

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 16, 2024
@pennam pennam merged commit c381c97 into arduino-libraries:master May 17, 2024
23 checks passed
@pennam pennam deleted the print-mqtt-err branch May 17, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants