Fix thing reconfiguration after wifi connection loss #455

pennam · 2024-05-09T12:03:29Z

No description provided.

making _sslio_closing not static anymore, so that we are able to stop bearsslclients independently from one another

codecov · 2024-05-09T12:10:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.22%. Comparing base (d79280a) to head (25e3252).

Additional details and impacted files

@@                Coverage Diff                 @@
##           new-ota-structure     #455   +/-   ##
==================================================
  Coverage              95.22%   95.22%           
==================================================
  Files                     32       32           
  Lines                   1467     1467           
==================================================
  Hits                    1397     1397           
  Misses                    70       70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-05-09T13:30:59Z

Memory usage change @ c43aa15

Board	flash	%	RAM for global variables	%
`arduino:esp32:nano_nora`	🔺 +68 - +80	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_edge:edge_control`	🔺 +64 - +64	+0.01 - +0.01	0 - 0	0.0 - 0.0
`arduino:mbed_giga:giga`	🔺 0 - +64	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_nano:nanorp2040connect`	🔺 0 - +32	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_nicla:nicla_vision`	🔺 0 - +64	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_opta:opta`	🔺 0 - +64	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	🔺 0 - +48	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:renesas_uno:unor4wifi`	🔺 +48 - +48	+0.02 - +0.02	0 - 0	0.0 - 0.0
`arduino:samd:mkr1000`	🔺 0 - +48	0.0 - +0.02	0 - 0	0.0 - 0.0
`arduino:samd:mkrgsm1400`	🔺 0 - +48	0.0 - +0.02	0 - 0	0.0 - 0.0
`arduino:samd:mkrnb1500`	🔺 0 - +48	0.0 - +0.02	0 - 0	0.0 - 0.0
`arduino:samd:mkrwan1300`	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
`arduino:samd:mkrwifi1010`	🔺 0 - +32	0.0 - +0.01	0 - 0	0.0 - 0.0
`arduino:samd:nano_33_iot`	🔺 0 - +32	0.0 - +0.01	0 - 0	0.0 - 0.0
`esp32:esp32:esp32`	🔺 +64 - +80	0.0 - +0.01	0 - 0	0.0 - 0.0
`esp8266:esp8266:huzzah`	🔺 +64 - +64	+0.01 - +0.01	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/ArduinoIoTCloud-Advanced` flash	%	`examples/ArduinoIoTCloud-Advanced` RAM for global variables	%	`examples/ArduinoIoTCloud-Basic` flash	%	`examples/ArduinoIoTCloud-Basic` RAM for global variables	%	`examples/ArduinoIoTCloud-Callbacks` flash	%	`examples/ArduinoIoTCloud-Callbacks` RAM for global variables	%	`examples/ArduinoIoTCloud-Schedule` flash	%	`examples/ArduinoIoTCloud-Schedule` RAM for global variables	%	`examples/utility/ArduinoIoTCloud_Travis_CI` flash	%	`examples/utility/ArduinoIoTCloud_Travis_CI` RAM for global variables	%	`examples/ArduinoIoTCloud-DeferredOTA` flash	%	`examples/ArduinoIoTCloud-DeferredOTA` RAM for global variables	%	`examples/utility/Provisioning` flash	%	`examples/utility/Provisioning` RAM for global variables	%	`examples/utility/SelfProvisioning` flash	%	`examples/utility/SelfProvisioning` RAM for global variables	%
`arduino:esp32:nano_nora`	72	0.0	0	0.0	68	0.0	0	0.0	68	0.0	0	0.0	80	0.0	0	0.0	80	0.0	0	0.0	68	0.0	0	0.0
`arduino:mbed_edge:edge_control`	64	0.01	0	0.0	64	0.01	0	0.0	64	0.01	0	0.0	64	0.01	0	0.0	64	0.01	0	0.0
`arduino:mbed_giga:giga`	64	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_nano:nanorp2040connect`	32	0.0	0	0.0	32	0.0	0	0.0	32	0.0	0	0.0	32	0.0	0	0.0	32	0.0	0	0.0	32	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_nicla:nicla_vision`	64	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_opta:opta`	64	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	64	0.0	0	0.0	0	0.0	0	0.0
`arduino:mbed_portenta:envie_m7`	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
`arduino:renesas_portenta:portenta_c33`	48	0.0	0	0.0	48	0.0	0	0.0	48	0.0	0	0.0	48	0.0	0	0.0	48	0.0	0	0.0					0	0.0	0	0.0
`arduino:renesas_uno:unor4wifi`	48	0.02	0	0.0	48	0.02	0	0.0	48	0.02	0	0.0	48	0.02	0	0.0	48	0.02	0	0.0
`arduino:samd:mkr1000`	40	0.02	0	0.0	48	0.02	0	0.0	40	0.02	0	0.0	40	0.02	0	0.0	40	0.02	0	0.0					0	0.0	0	0.0
`arduino:samd:mkrgsm1400`	48	0.02	0	0.0	40	0.02	0	0.0	48	0.02	0	0.0	40	0.02	0	0.0	40	0.02	0	0.0					0	0.0	0	0.0
`arduino:samd:mkrnb1500`	48	0.02	0	0.0	40	0.02	0	0.0	48	0.02	0	0.0	40	0.02	0	0.0	40	0.02	0	0.0					0	0.0	0	0.0
`arduino:samd:mkrwan1300`	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:mkrwifi1010`	32	0.01	0	0.0	32	0.01	0	0.0	32	0.01	0	0.0	32	0.01	0	0.0	32	0.01	0	0.0	32	0.01	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`arduino:samd:nano_33_iot`	32	0.01	0	0.0	32	0.01	0	0.0	32	0.01	0	0.0	32	0.01	0	0.0	32	0.01	0	0.0	32	0.01	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
`esp32:esp32:esp32`	68	0.01	0	0.0	68	0.01	0	0.0	72	0.01	0	0.0	72	0.01	0	0.0	80	0.01	0	0.0	64	0.0	0	0.0
`esp8266:esp8266:huzzah`	64	0.01	0	0.0	64	0.01	0	0.0	64	0.01	0	0.0	64	0.01	0	0.0	64	0.01	0	0.0

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/ArduinoIoTCloud-Callbacks<br>flash,%,examples/ArduinoIoTCloud-Callbacks<br>RAM for global variables,%,examples/ArduinoIoTCloud-Schedule<br>flash,%,examples/ArduinoIoTCloud-Schedule<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/ArduinoIoTCloud-DeferredOTA<br>flash,%,examples/ArduinoIoTCloud-DeferredOTA<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:esp32:nano_nora,72,0.0,0,0.0,68,0.0,0,0.0,68,0.0,0,0.0,80,0.0,0,0.0,80,0.0,0,0.0,68,0.0,0,0.0
arduino:mbed_edge:edge_control,64,0.01,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0,,,,
arduino:mbed_giga:giga,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,32,0.0,0,0.0,32,0.0,0,0.0,32,0.0,0,0.0,32,0.0,0,0.0,32,0.0,0,0.0,32,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_opta:opta,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,
arduino:renesas_portenta:portenta_c33,48,0.0,0,0.0,48,0.0,0,0.0,48,0.0,0,0.0,48,0.0,0,0.0,48,0.0,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:renesas_uno:unor4wifi,48,0.02,0,0.0,48,0.02,0,0.0,48,0.02,0,0.0,48,0.02,0,0.0,48,0.02,0,0.0,,,,,,,,,,,,
arduino:samd:mkr1000,40,0.02,0,0.0,48,0.02,0,0.0,40,0.02,0,0.0,40,0.02,0,0.0,40,0.02,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,48,0.02,0,0.0,40,0.02,0,0.0,48,0.02,0,0.0,40,0.02,0,0.0,40,0.02,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,48,0.02,0,0.0,40,0.02,0,0.0,48,0.02,0,0.0,40,0.02,0,0.0,40,0.02,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,,,,,
arduino:samd:mkrwifi1010,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,32,0.01,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,68,0.01,0,0.0,68,0.01,0,0.0,72,0.01,0,0.0,72,0.01,0,0.0,80,0.01,0,0.0,64,0.0,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,64,0.01,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0,,,,,,,,,,,,

…e amount of time

pennam · 2024-05-16T12:08:55Z

Manually merged here d755efe

pennam and others added 30 commits April 15, 2024 12:08

Move properties containers inside class implementation

059b318

Add commands definitions

6bc1aa8

Add MessageStream interface

220c04e

Add CloudProcess interface

2294fd7

Add ArduinoCloudThing

7d266e8

TimeService: make isTimeValid public

ef6b3a6

ArduinoIoTCloudTCP: Use isTimeValid() to check NTP time

20831f5

ArduinoIoTCloudTCP: adapt state machine to use Thing process

0d69bbb

Add ArduinoCloudDevice

af14054

ArduinoIoTCloudTCP: adapt state machine to use Device process

8420fde

Cloud: initialize thing id to non null

358194b

Defining encoder/decoder interfaces

20d24e4

CBOR encoder and decoder implementation for Command protocol model

b98e3d2

Add tests for encoder and decoder

f13300a

Extend Commands.h to include new Command protocol model

24de8e6

ArduinoIoTCloudTCP: switch to messages

8f0c243

ArduinoIoTCloudDevice: switch to messages

0008b17

BearSSLClient: allow configuration after object creation

52bf98d

BearSSLClient: allow clients to stop independently

fbf03e1

making _sslio_closing not static anymore, so that we are able to stop bearsslclients independently from one another

BearSSLClient: removing trailing white spaces

8e6184a

BearSSLClient: adding FIXME comment

1ba3e3a

Add TLSClientMqtt

fa514ea

Add TLSClientOta

a92a57c

BearSLL: increase input buffer size to allow file downloading

34e8ad5

Removing x509_crt_bundle_len since not used anywhere

63b0840

Add ArduinoLCC certificate inside certificate bundle

561c767

BearSSL Trust Anchors: remove ces.iot.arduino.cc

af78334

UNO R4 WiFi: remove unused certificate bundle

a42f164

CI: added ArduinoHttpClient as dependency

6b0883b

removing unused dependencies: ESP and Portente OTA

8569ac1

andreagilardoni added 4 commits May 9, 2024 11:44

CI: removed unused libraries

b6bd5af

changing include enrtypoint for OTA

232e25a

included LZSSDecoder library beforme making it a library

e36cf27

removed FlashSHA256.h

e616374

per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels May 9, 2024

andreagilardoni and others added 14 commits May 10, 2024 10:26

adjusting OTA.h

6258eb0

defining OTAInterface

8ac52a9

renamed files containing implementation of OTA HAL functions

ddef056

added stub implementation of OTA HAL classes

6ae5393

implemented stm32h7 ota class

b010d91

implemented rp2040 ota class

86cbcab

implemented unor4 ota class

c7ed12b

implemented esp32 ota class

7f9476c

implemented samd ota class

60d2886

disabling ota on mkrgsm1400

eb6311c

ArduinoIoTCloud integration

c4b0110

Ota default interface: making the download run at least a configurabl…

7648544

…e amount of time

Ota interface Default: adding download progress status report

d79280a

Fix thing reconfiguration after wifi connection loss

25e3252

andreagilardoni force-pushed the fix-on-wifi-loss branch from c43aa15 to 25e3252 Compare May 10, 2024 08:30

andreagilardoni force-pushed the new-ota-structure branch from 40bf5f7 to d79280a Compare May 10, 2024 08:30

pennam mentioned this pull request May 15, 2024

Fix thing property reconfiguration after wifi loss #459

Merged

pennam force-pushed the new-ota-structure branch from d79280a to 98406e4 Compare May 16, 2024 12:05

pennam closed this May 16, 2024

per1234 added the conclusion: duplicate Has already been submitted label May 16, 2024

pennam deleted the fix-on-wifi-loss branch May 23, 2024 06:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix thing reconfiguration after wifi connection loss #455

Fix thing reconfiguration after wifi connection loss #455

pennam commented May 9, 2024

codecov bot commented May 9, 2024 •

edited

Loading

github-actions bot commented May 9, 2024

pennam commented May 16, 2024

Fix thing reconfiguration after wifi connection loss #455

Fix thing reconfiguration after wifi connection loss #455

Conversation

pennam commented May 9, 2024

codecov bot commented May 9, 2024 • edited Loading

Codecov Report

github-actions bot commented May 9, 2024

pennam commented May 16, 2024

codecov bot commented May 9, 2024 •

edited

Loading