Optimized getTime management #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilcato
force-pushed
the
optimize-get-time-management
branch
from
7ccf79b to
221c922
Compare
ubidefeo
approved these changes
Mar 21, 2019
There was a problem hiding this comment.
this looks clean and leaner.
@lxrobotics how hard is it to implement #43 over this?
|
I don't believe there will be a problem 👍 You can merge this and I shall perform a rebase on #43. |
|
all clear for the rebase for #43 , @lxrobotics |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed CONNECTION_STATE_GETTIME state in the connection manager classes.
The status IOT_STATUS_CLOUD_CONNECTING and IOT_STATUS_CLOUD_RECONNECTING are able to loop until a valid time is returned. Furthermore, with the fallback to time.arduino.cc the need to retry has a very low probability.