-
Notifications
You must be signed in to change notification settings - Fork 80
Reorder and simplify addPropertyReal methods #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder and simplify addPropertyReal methods #343
Conversation
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
=======================================
Coverage 94.87% 94.87%
=======================================
Files 27 27
Lines 1113 1113
=======================================
Hits 1056 1056
Misses 57 57
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
0ff8433
to
d344c46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I'm a big fan of any kind of API surface reduction, so kudos 😉
Thanks for your review @aentinger. You made me remember that after i've reverted cd98ce2 also the followings two commits are no more needed: So i think i will cleanup this PR dropping all that is not necessary 🙇 |
0ff8433
to
f137056
Compare
Memory usage change @ f137056
Click for full report table
Click for full report CSV
|
Glad that looking over your PR was helpful in some way =) |
During the
thing_id
discovery work #297 i've added unnecessary methods to the public space.The goal of this pr is to:
reorder
addPropertyReal
methods in ArduinoIoTCloud.cpp to make more clear who is calling whoremove unnecessary
addPropertyReal
methods from public space: the user should not be able to select the property container because all user properties have to be added to the_thing_property_container
.