print troubleshooting info, added broker port, general cleanup #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- defined DEFAULT_BROKER_PORT (see next) - added brokerPort private member (uint16_t because of how it is defined in MQTT client) - added possibility to pass an alternative Broker port after the address - added getBrokerPort() method - added printDebugInfo() method to ArduinoIoTCloud, to allow user to print out info useful for troubleshooting: Broker address:port, Thing ID, Device ID WiFiConnectionManager: - tweaked interval time for GETTIME - added check for firmwareVersion() required version (delays 5 seconds if version is older than latest fixed ones, but still moves forward) - cleaned up a couple of debugMessage formatted strings Both: removed *msgBuffer=0 from anywhere the buffer was filled with a new message
aentinger
approved these changes
Feb 14, 2019
| @@ -33,7 +33,7 @@ class WiFiConnectionManager : public ConnectionManager { | |||
|
|
|||
| const int CHECK_INTERVAL_INIT = 100; | |||
| const int CHECK_INTERVAL_CONNECTING = 500; | |||
| const int CHECK_INTERVAL_GETTIME = 100; | |||
| const int CHECK_INTERVAL_GETTIME = 666; | |||
There was a problem hiding this comment.
Any specific reason the value is exactly 666? ;)
- added printDebugInfo() in example setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArduinoIoTCloudClass:
WiFiConnectionManager:
Both:
removed *msgBuffer=0 from anywhere the buffer was filled with a new message