Avoid multivalue properties split by pennam · Pull Request #293 · arduino-libraries/ArduinoIoTCloud

Clear has_been_modified_in_callback after a succesful append

pennam

committed

Create CHECK_CBOR_MULTI macro to return CborErrorTooManyItems error if the whole property cannot be appended to the CBOR buffer. Doing so the complete CBOR message will be discarded.

pennam

committed

Use CHECK_CBOR_MULTI in all multivalue properties

pennam

committed

Proceed encoding properties only if no error occurred

pennam

committed

Use a more fair way to send properties to the cloud

pennam

committed

Move last_property index out of CBOREncoder::encode function and fix unit tests

pennam

committed

Add bool flag and functions to handle properties appended to a CBOR message that may be discarded

pennam

committed

Instead of simply discard the message containing a splitted multivalue property, do not advance the property index and mark discarded properties has appended but not sended.

pennam

committed

In case of cbor_encoder_close_container failure, reduce the number of properties to be appended by one and retry send

pennam

committed

Make more explicit and clear that properties are echoed back to the cloud even if not changed in callback

pennam

committed

Use a constant value for CBOR_ENCODER_NO_PROPERTIES_LIMIT

pennam

committed

Use bool variables to make if condition more readable

pennam

committed

Use for loop instead of for_each to be able to break loop when condition is met

pennam

committed

Change test buffer size in order to match real application buffer size

pennam

committed

Change test case in order to match the new buffer size

pennam

committed

Add test case to check multivalue properties split

pennam

committed

Use FSM to encode CBOR messages

pennam

committed

Add test for a single property not fitting inside 256 bytes

pennam

committed

Add custom and dedicated error for splitted items

pennam

committed

Declare last_checked_property_index as protected variable of ArduinoIoTCloud

pennam

committed

Merge FinishAppend and AdvancePropertyContainer encoder states

pennam

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Avoid multivalue properties split#293

Avoid multivalue properties split#293
pennam merged 21 commits intoarduino-libraries:masterfrom
pennam:avoid_multi_split

Commits on Jan 18, 2022

Clear has_been_modified_in_callback after a succesful append

Create CHECK_CBOR_MULTI macro to return CborErrorTooManyItems error if the whole property cannot be appended to the CBOR buffer. Doing so the complete CBOR message will be discarded.

Use CHECK_CBOR_MULTI in all multivalue properties

Proceed encoding properties only if no error occurred

Use a more fair way to send properties to the cloud

Move last_property index out of CBOREncoder::encode function and fix unit tests

Add bool flag and functions to handle properties appended to a CBOR message that may be discarded

Instead of simply discard the message containing a splitted multivalue property, do not advance the property index and mark discarded properties has appended but not sended.

In case of cbor_encoder_close_container failure, reduce the number of properties to be appended by one and retry send

Make more explicit and clear that properties are echoed back to the cloud even if not changed in callback

Use a constant value for CBOR_ENCODER_NO_PROPERTIES_LIMIT

Use bool variables to make if condition more readable

Use for loop instead of for_each to be able to break loop when condition is met

Change test buffer size in order to match real application buffer size

Change test case in order to match the new buffer size

Add test case to check multivalue properties split

Use FSM to encode CBOR messages

Add test for a single property not fitting inside 256 bytes

Add custom and dedicated error for splitted items

Declare last_checked_property_index as protected variable of ArduinoIoTCloud

Merge FinishAppend and AdvancePropertyContainer encoder states

Avoid multivalue properties split#293pennam merged 21 commits intoarduino-libraries:masterarduino-libraries/ArduinoIoTCloud:masterfrom pennam:avoid_multi_splitpennam/ArduinoIoTCloud:avoid_multi_splitCopy head branch name to clipboard

Commits

Commits on Jan 18, 2022

Avoid multivalue properties split#293
pennam merged 21 commits intoarduino-libraries:masterfrom
pennam:avoid_multi_split