Code

Avoid multivalue properties split#293

Code

Merged

pennam merged 21 commits intoarduino-libraries:masterarduino-libraries/ArduinoIoTCloud:masterfrom

pennam:avoid_multi_splitpennam/ArduinoIoTCloud:avoid_multi_splitCopy head branch name to clipboard

Jan 20, 2022

Commits

Commits on Jan 18, 2022

• Clear has_been_modified_in_callback after a succesful append

  pennam

  committed
  f0328c0

  Copy full SHA for f0328c0

• Create CHECK_CBOR_MULTI macro to return CborErrorTooManyItems error if the whole property cannot be appended to the CBOR buffer. Doing so the complete CBOR message will be discarded.

  pennam

  committed
  6136b40

  Copy full SHA for 6136b40

• Use CHECK_CBOR_MULTI in all multivalue properties

  pennam

  committed
  a89f2d1

  Copy full SHA for a89f2d1

• Proceed encoding properties only if no error occurred

  pennam

  committed
  7141e71

  Copy full SHA for 7141e71

• Use a more fair way to send properties to the cloud

  pennam

  committed
  f16a696

  Copy full SHA for f16a696

• Move last_property index out of CBOREncoder::encode function and fix unit tests

  pennam

  committed
  f35fe82

  Copy full SHA for f35fe82

• Add bool flag and functions to handle properties appended to a CBOR message that may be discarded

  pennam

  committed
  5c416f2

  Copy full SHA for 5c416f2

• Instead of simply discard the message containing a splitted multivalue property, do not advance the property index and mark discarded properties has appended but not sended.

  Show description for 803bcde
  pennam

  committed
  803bcde

  Copy full SHA for 803bcde

• In case of cbor_encoder_close_container failure, reduce the number of properties to be appended by one and retry send

  pennam

  committed
  bb33feb

  Copy full SHA for bb33feb

• Make more explicit and clear that properties are echoed back to the cloud even if not changed in callback

  pennam

  committed
  591224e

  Copy full SHA for 591224e

• Use a constant value for CBOR_ENCODER_NO_PROPERTIES_LIMIT

  pennam

  committed
  7508607

  Copy full SHA for 7508607

• Use bool variables to make if condition more readable

  pennam

  committed
  537e722

  Copy full SHA for 537e722

• Use for loop instead of for_each to be able to break loop when condition is met

  pennam

  committed
  cc3aa38

  Copy full SHA for cc3aa38

• Change test buffer size in order to match real application buffer size

  pennam

  committed
  2a8c879

  Copy full SHA for 2a8c879

• Change test case in order to match the new buffer size

  pennam

  committed
  4b991e3

  Copy full SHA for 4b991e3

• Add test case to check multivalue properties split

  pennam

  committed
  f6af6a7

  Copy full SHA for f6af6a7

• Use FSM to encode CBOR messages

  pennam

  committed
  61033be

  Copy full SHA for 61033be

• Add test for a single property not fitting inside 256 bytes

  pennam

  committed
  bba3144

  Copy full SHA for bba3144

• Add custom and dedicated error for splitted items

  pennam

  committed
  e285273

  Copy full SHA for e285273

• Declare last_checked_property_index as protected variable of ArduinoIoTCloud

  pennam

  committed
  5576a60

  Copy full SHA for 5576a60

• Merge FinishAppend and AdvancePropertyContainer encoder states

  pennam

  committed
  78b3158

  Copy full SHA for 78b3158