Change CloudTime from CloudFloat to CloudUnsignedInt #277

pennam · 2021-09-29T13:21:46Z

This pr adds a new CloudUnsignedInt type and changes CloudTime from CloudFloat to CloudUnsignedInt

/cc @eclipse1985

github-actions · 2021-09-29T13:51:38Z

Memory usage change @ 616396f

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m4	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed:envie_m7	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrgsm1400	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrnb1500	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:nano_33_iot	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
esp32:esp32:esp32	🔺 +244 - +248	+0.02 - +0.02	0 - 0	0.0 - 0.0
esp8266:esp8266:huzzah	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/ArduinoIoTCloud-Advanced flash	%	examples/ArduinoIoTCloud-Basic flash	%	examples/utility/ArduinoIoTCloud_Travis_CI flash	%	examples/utility/Provisioning flash	%	examples/utility/Provisioning RAM for global variables	%	examples/utility/SelfProvisioning flash	%	examples/utility/SelfProvisioning RAM for global variables	%
arduino:mbed:envie_m4	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed:envie_m7	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed_nano:nanorp2040connect	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkr1000	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrgsm1400	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrnb1500	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrwan1300	0	0.0	0	0.0	0	0.0
arduino:samd:mkrwifi1010	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:nano_33_iot	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
esp32:esp32:esp32	248	0.02	248	0.02	244	0.02
esp8266:esp8266:huzzah	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,248,0.02,0,0.0,248,0.02,0,0.0,244,0.02,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,

aentinger · 2021-09-30T04:12:24Z

Good Morning @pennam 👋 ☕
Possibly I've missed this, but did you extend the unit tests to also cover the new CloudUnsignedInt/unsigned int property?

pennam · 2021-09-30T07:47:16Z

Hi @aentinger, you are right, i did not add them. Let me do it 💪

codecov-commenter · 2021-10-04T11:33:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.31%. Comparing base (1920b54) to head (7a85b16).
Report is 642 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   95.15%   95.31%   +0.15%     
==========================================
  Files          24       25       +1     
  Lines         867      896      +29     
==========================================
+ Hits          825      854      +29     
  Misses         42       42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2021-10-04T11:54:07Z

Memory usage change @ 7a85b16

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m4	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed:envie_m7	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrgsm1400	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrnb1500	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:nano_33_iot	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
esp32:esp32:esp32	🔺 +244 - +248	+0.02 - +0.02	0 - 0	0.0 - 0.0
esp8266:esp8266:huzzah	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/ArduinoIoTCloud-Advanced flash	%	examples/ArduinoIoTCloud-Basic flash	%	examples/utility/ArduinoIoTCloud_Travis_CI flash	%	examples/utility/Provisioning flash	%	examples/utility/Provisioning RAM for global variables	%	examples/utility/SelfProvisioning flash	%	examples/utility/SelfProvisioning RAM for global variables	%
arduino:mbed:envie_m4	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed:envie_m7	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:mbed_nano:nanorp2040connect	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkr1000	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrgsm1400	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrnb1500	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkrwan1300	0	0.0	0	0.0	0	0.0
arduino:samd:mkrwifi1010	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:nano_33_iot	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0
esp32:esp32:esp32	248	0.02	248	0.02	244	0.02
esp8266:esp8266:huzzah	0	0.0	0	0.0	0	0.0

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,248,0.02,0,0.0,248,0.02,0,0.0,244,0.02,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,

pennam · 2021-10-04T14:13:39Z

@aentinger should be better now, i've added tests for encoding/decoding CloudTime property so it will cover also the CloudUnsignedInt type.

I was a bit unsure, but like for the other basic types (CloudInt, CloudBool...) i did not add any test for operators overloading.

aentinger · 2021-10-05T04:18:05Z

@aentinger should be better now, i've added tests for encoding/decoding CloudTime property so it will cover also the CloudUnsignedInt type.

Yes, that's perfectly fine.

pennam added 2 commits September 29, 2021 10:28

Add CloudUnsignedInt type

aba4ee9

Make CloudTime an unsigned int

ceda67f

pennam requested a review from aentinger September 29, 2021 13:21

pennam added 2 commits September 29, 2021 15:25

Fix threshold check

bd97dbe

Fix unit test error

616396f

pennam force-pushed the cloud_time branch from 4b505d6 to 616396f Compare September 29, 2021 13:26

pennam mentioned this pull request Oct 4, 2021

Use mbed rtc API instead of always request remote time #273

Merged

pennam added 3 commits October 4, 2021 13:31

Add decode test for CloudTime type

40fa1ba

Add encode test for CloudTime type

f7e5510

Fix typos in comments

7a85b16

pennam merged commit 5213f2d into arduino-libraries:master Oct 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Change CloudTime from CloudFloat to CloudUnsignedInt #277

Change CloudTime from CloudFloat to CloudUnsignedInt #277

Uh oh!

pennam commented Sep 29, 2021

Uh oh!

github-actions bot commented Sep 29, 2021

Uh oh!

aentinger commented Sep 30, 2021

Uh oh!

pennam commented Sep 30, 2021

Uh oh!

codecov-commenter commented Oct 4, 2021 •

edited by codecov bot

Loading

Uh oh!

github-actions bot commented Oct 4, 2021

Uh oh!

pennam commented Oct 4, 2021 •

edited

Loading

Uh oh!

aentinger commented Oct 5, 2021

Uh oh!

Uh oh!

Change CloudTime from CloudFloat to CloudUnsignedInt #277

Change CloudTime from CloudFloat to CloudUnsignedInt #277

Uh oh!

Conversation

pennam commented Sep 29, 2021

Uh oh!

github-actions bot commented Sep 29, 2021

Uh oh!

aentinger commented Sep 30, 2021

Uh oh!

pennam commented Sep 30, 2021

Uh oh!

codecov-commenter commented Oct 4, 2021 • edited by codecov bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 4, 2021

Uh oh!

pennam commented Oct 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aentinger commented Oct 5, 2021

Uh oh!

Uh oh!

codecov-commenter commented Oct 4, 2021 •

edited by codecov bot

Loading

pennam commented Oct 4, 2021 •

edited

Loading