Wdog trigger during binary download decompressio for portenta #261

pennam · 2021-06-10T20:58:35Z

Needs arduino-libraries/Arduino_Portenta_OTA#10

TODO drop Enable debug output commit

codecov-commenter · 2021-06-10T21:00:23Z

Codecov Report

Merging #261 (93ec0f4) into master (5d055ae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files          24       24           
  Lines         867      867           
=======================================
  Hits          825      825           
  Misses         42       42

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d055ae...93ec0f4. Read the comment docs.

github-actions · 2021-06-10T21:32:39Z

Memory usage change @ 2802b54

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m4	🔺 +200 - +328	+0.02 - +0.03	0 - 0	0.0 - 0.0
arduino:mbed:envie_m7	🔺 +416 - +552	+0.05 - +0.07	0 - 0	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	🔺 0 - +152	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	🔺 +192 - +288	+0.07 - +0.11	0 - 0	0.0 - 0.0
arduino:samd:mkrgsm1400	🔺 +192 - +368	+0.07 - +0.14	0 - 0	0.0 - 0.0
arduino:samd:mkrnb1500	🔺 +192 - +288	+0.07 - +0.11	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1300	🔺 +112 - +112	+0.04 - +0.04	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	🔺 0 - +376	0.0 - +0.14	0 - 0	0.0 - 0.0
arduino:samd:nano_33_iot	🔺 0 - +376	0.0 - +0.14	0 - 0	0.0 - 0.0
esp32:esp32:esp32	🔺 +272 - +272	+0.02 - +0.02	0 - 0	0.0 - 0.0
esp8266:esp8266:huzzah	🔺 +296 - +296	+0.03 - +0.03	🔺 +172 - +172	+0.21 - +0.21

Click for full report table

Board	examples/ArduinoIoTCloud-Advanced flash	%	examples/ArduinoIoTCloud-Advanced RAM for global variables	%	examples/ArduinoIoTCloud-Basic flash	%	examples/ArduinoIoTCloud-Basic RAM for global variables	%	examples/utility/ArduinoIoTCloud_Travis_CI flash	%	examples/utility/ArduinoIoTCloud_Travis_CI RAM for global variables	%	examples/utility/Provisioning flash	%	examples/utility/Provisioning RAM for global variables	%	examples/utility/SelfProvisioning flash	%	examples/utility/SelfProvisioning RAM for global variables	%
arduino:mbed:envie_m4	264	0.03	0	0.0	328	0.03	0	0.0	328	0.03	0	0.0	200	0.02	0	0.0
arduino:mbed:envie_m7	480	0.06	0	0.0	552	0.07	0	0.0	544	0.07	0	0.0	416	0.05	0	0.0
arduino:mbed_nano:nanorp2040connect	152	0.0	0	0.0	152	0.0	0	0.0	152	0.0	0	0.0	72	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkr1000	288	0.11	0	0.0	288	0.11	0	0.0	288	0.11	0	0.0	192	0.07	0	0.0
arduino:samd:mkrgsm1400	368	0.14	0	0.0	368	0.14	0	0.0	368	0.14	0	0.0	192	0.07	0	0.0
arduino:samd:mkrnb1500	288	0.11	0	0.0	288	0.11	0	0.0	280	0.11	0	0.0	192	0.07	0	0.0
arduino:samd:mkrwan1300	112	0.04	0	0.0	112	0.04	0	0.0	112	0.04	0	0.0
arduino:samd:mkrwifi1010	376	0.14	0	0.0	376	0.14	0	0.0	376	0.14	0	0.0	192	0.07	0	0.0	0	0.0	0	0.0
arduino:samd:nano_33_iot	376	0.14	0	0.0	376	0.14	0	0.0	376	0.14	0	0.0	192	0.07	0	0.0	0	0.0	0	0.0
esp32:esp32:esp32	272	0.02	0	0.0	272	0.02	0	0.0	272	0.02	0	0.0
esp8266:esp8266:huzzah	296	0.03	172	0.21	296	0.03	172	0.21	296	0.03	172	0.21

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,264,0.03,0,0.0,328,0.03,0,0.0,328,0.03,0,0.0,200,0.02,0,0.0
arduino:mbed:envie_m7,480,0.06,0,0.0,552,0.07,0,0.0,544,0.07,0,0.0,416,0.05,0,0.0
arduino:mbed_nano:nanorp2040connect,152,0.0,0,0.0,152,0.0,0,0.0,152,0.0,0,0.0,72,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,288,0.11,0,0.0,288,0.11,0,0.0,288,0.11,0,0.0,192,0.07,0,0.0,,,,
arduino:samd:mkrgsm1400,368,0.14,0,0.0,368,0.14,0,0.0,368,0.14,0,0.0,192,0.07,0,0.0,,,,
arduino:samd:mkrnb1500,288,0.11,0,0.0,288,0.11,0,0.0,280,0.11,0,0.0,192,0.07,0,0.0,,,,
arduino:samd:mkrwan1300,112,0.04,0,0.0,112,0.04,0,0.0,112,0.04,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,376,0.14,0,0.0,376,0.14,0,0.0,376,0.14,0,0.0,192,0.07,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,376,0.14,0,0.0,376,0.14,0,0.0,376,0.14,0,0.0,192,0.07,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,272,0.02,0,0.0,272,0.02,0,0.0,272,0.02,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,296,0.03,172,0.21,296,0.03,172,0.21,296,0.03,172,0.21,,,,,,,,

aentinger · 2021-06-11T06:02:47Z

src/ArduinoIoTCloudTCP.cpp

@@ -286,10 +286,9 @@ int ArduinoIoTCloudTCP::begin(bool const enable_watchdog, String brokerAddress,
  if (enable_watchdog) {
    watchdog_enable();
 #ifdef WIFI_HAS_FEED_WATCHDOG_FUNC
-      WiFi.setFeedWatchdogFunc(watchdog_reset);
-#endif
+      WiFi.setFeedWatchdogFunc((voidPrtFuncPtr)watchdog_reset);


Bad idea ;)

fixed with 21c15bb

github-actions · 2021-06-11T12:51:46Z

Memory usage change @ 93ec0f4

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m4	🔺 +200 - +328	+0.02 - +0.03	0 - 0	0.0 - 0.0
arduino:mbed:envie_m7	🔺 +416 - +552	+0.05 - +0.07	0 - 0	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	🔺 0 - +152	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	🔺 +192 - +288	+0.07 - +0.11	0 - 0	0.0 - 0.0
arduino:samd:mkrgsm1400	🔺 +192 - +368	+0.07 - +0.14	0 - 0	0.0 - 0.0
arduino:samd:mkrnb1500	🔺 +192 - +288	+0.07 - +0.11	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1300	🔺 +112 - +112	+0.04 - +0.04	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	🔺 0 - +376	0.0 - +0.14	0 - 0	0.0 - 0.0
arduino:samd:nano_33_iot	🔺 0 - +376	0.0 - +0.14	0 - 0	0.0 - 0.0
esp32:esp32:esp32	🔺 +272 - +272	+0.02 - +0.02	0 - 0	0.0 - 0.0
esp8266:esp8266:huzzah	🔺 +296 - +296	+0.03 - +0.03	🔺 +172 - +172	+0.21 - +0.21

Click for full report table

Board	examples/ArduinoIoTCloud-Advanced flash	%	examples/ArduinoIoTCloud-Advanced RAM for global variables	%	examples/ArduinoIoTCloud-Basic flash	%	examples/ArduinoIoTCloud-Basic RAM for global variables	%	examples/utility/ArduinoIoTCloud_Travis_CI flash	%	examples/utility/ArduinoIoTCloud_Travis_CI RAM for global variables	%	examples/utility/Provisioning flash	%	examples/utility/Provisioning RAM for global variables	%	examples/utility/SelfProvisioning flash	%	examples/utility/SelfProvisioning RAM for global variables	%
arduino:mbed:envie_m4	264	0.03	0	0.0	328	0.03	0	0.0	328	0.03	0	0.0	200	0.02	0	0.0
arduino:mbed:envie_m7	480	0.06	0	0.0	552	0.07	0	0.0	544	0.07	0	0.0	416	0.05	0	0.0
arduino:mbed_nano:nanorp2040connect	152	0.0	0	0.0	152	0.0	0	0.0	152	0.0	0	0.0	72	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkr1000	288	0.11	0	0.0	288	0.11	0	0.0	288	0.11	0	0.0	192	0.07	0	0.0
arduino:samd:mkrgsm1400	368	0.14	0	0.0	368	0.14	0	0.0	368	0.14	0	0.0	192	0.07	0	0.0
arduino:samd:mkrnb1500	288	0.11	0	0.0	288	0.11	0	0.0	280	0.11	0	0.0	192	0.07	0	0.0
arduino:samd:mkrwan1300	112	0.04	0	0.0	112	0.04	0	0.0	112	0.04	0	0.0
arduino:samd:mkrwifi1010	376	0.14	0	0.0	376	0.14	0	0.0	376	0.14	0	0.0	192	0.07	0	0.0	0	0.0	0	0.0
arduino:samd:nano_33_iot	376	0.14	0	0.0	376	0.14	0	0.0	376	0.14	0	0.0	192	0.07	0	0.0	0	0.0	0	0.0
esp32:esp32:esp32	272	0.02	0	0.0	272	0.02	0	0.0	272	0.02	0	0.0
esp8266:esp8266:huzzah	296	0.03	172	0.21	296	0.03	172	0.21	296	0.03	172	0.21

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,264,0.03,0,0.0,328,0.03,0,0.0,328,0.03,0,0.0,200,0.02,0,0.0
arduino:mbed:envie_m7,480,0.06,0,0.0,552,0.07,0,0.0,544,0.07,0,0.0,416,0.05,0,0.0
arduino:mbed_nano:nanorp2040connect,152,0.0,0,0.0,152,0.0,0,0.0,152,0.0,0,0.0,72,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,288,0.11,0,0.0,288,0.11,0,0.0,288,0.11,0,0.0,192,0.07,0,0.0,,,,
arduino:samd:mkrgsm1400,368,0.14,0,0.0,368,0.14,0,0.0,368,0.14,0,0.0,192,0.07,0,0.0,,,,
arduino:samd:mkrnb1500,288,0.11,0,0.0,288,0.11,0,0.0,280,0.11,0,0.0,192,0.07,0,0.0,,,,
arduino:samd:mkrwan1300,112,0.04,0,0.0,112,0.04,0,0.0,112,0.04,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,376,0.14,0,0.0,376,0.14,0,0.0,376,0.14,0,0.0,192,0.07,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,376,0.14,0,0.0,376,0.14,0,0.0,376,0.14,0,0.0,192,0.07,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,272,0.02,0,0.0,272,0.02,0,0.0,272,0.02,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,296,0.03,172,0.21,296,0.03,172,0.21,296,0.03,172,0.21,,,,,,,,

…called during decompression phase

github-actions · 2021-06-14T13:50:42Z

Memory usage change @ af31191

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m4	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed:envie_m7	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrgsm1400	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrnb1500	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:nano_33_iot	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
esp32:esp32:esp32	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
esp8266:esp8266:huzzah	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/utility/Provisioning flash	%	examples/utility/Provisioning RAM for global variables	%	examples/utility/SelfProvisioning flash	%	examples/utility/SelfProvisioning RAM for global variables	%
arduino:mbed:envie_m4	0	0.0	0	0.0
arduino:mbed:envie_m7	0	0.0	0	0.0
arduino:mbed_nano:nanorp2040connect	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:mkr1000	0	0.0	0	0.0
arduino:samd:mkrgsm1400	0	0.0	0	0.0
arduino:samd:mkrnb1500	0	0.0	0	0.0
arduino:samd:mkrwan1300
arduino:samd:mkrwifi1010	0	0.0	0	0.0	0	0.0	0	0.0
arduino:samd:nano_33_iot	0	0.0	0	0.0	0	0.0	0	0.0
esp32:esp32:esp32
esp8266:esp8266:huzzah

Click for full report CSV

Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,

aentinger

LGTM 👍 Thank you @pennam 🚀

pennam mentioned this pull request Jun 10, 2021

Align wdog feed function pointer to mbed core arduino-libraries/WiFiNINA#187

Closed

aentinger suggested changes Jun 11, 2021

View reviewed changes

pennam requested a review from aentinger June 11, 2021 13:29

pennam changed the title ~~Wdog trigger during decompressio for portenta~~ Wdog trigger during binary download decompressio for portenta Jun 11, 2021

pennam mentioned this pull request Jun 11, 2021

Add API to WiFi class to configure wdog feed function arduino/ArduinoCore-mbed#258

Merged

pennam force-pushed the wdog_portenta branch from 93ec0f4 to 4b7e53a Compare June 14, 2021 13:19

pennam added 4 commits June 14, 2021 15:26

pass wdog feed function to Arduino_Portenta_OTA library so it can be …

858d6f8

…called during decompression phase

Remove stray newline

34752c6

align defines with Arduino_Portenta_OTA and ArduinoCore-mbed

95e960c

Add WiFi.h include for ARDUINO_PORTENTA_H7_WIFI_HAS_FEED_WATCHDOG_FUNC

af31191

pennam force-pushed the wdog_portenta branch from 4b7e53a to af31191 Compare June 14, 2021 13:29

aentinger approved these changes Jun 15, 2021

View reviewed changes

aentinger merged commit df474bc into arduino-libraries:master Jun 15, 2021

pennam deleted the wdog_portenta branch May 17, 2024 09:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wdog trigger during binary download decompressio for portenta #261

Wdog trigger during binary download decompressio for portenta #261

pennam commented Jun 10, 2021

codecov-commenter commented Jun 10, 2021 •

edited

Loading

github-actions bot commented Jun 10, 2021

aentinger Jun 11, 2021

pennam Jun 11, 2021

github-actions bot commented Jun 11, 2021

github-actions bot commented Jun 14, 2021

aentinger left a comment

Wdog trigger during binary download decompressio for portenta #261

Wdog trigger during binary download decompressio for portenta #261

Conversation

pennam commented Jun 10, 2021

codecov-commenter commented Jun 10, 2021 • edited Loading

Codecov Report

github-actions bot commented Jun 10, 2021

aentinger Jun 11, 2021

Choose a reason for hiding this comment

pennam Jun 11, 2021

Choose a reason for hiding this comment

github-actions bot commented Jun 11, 2021

github-actions bot commented Jun 14, 2021

aentinger left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jun 10, 2021 •

edited

Loading