Fix: Immediately trigger a sync request on the first time this function is reached #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
=======================================
Coverage 95.15% 95.15%
=======================================
Files 24 24
Lines 867 867
=======================================
Hits 825 825
Misses 42 42 Continue to review full report at Codecov.
|
…on is reached. It does not make sense to let the user wait until the timeout has passed (which is now even 30 seconds) long. Therefore the logic should trigger an immediate sync the first time this function is reached.
aentinger
force-pushed
the
fix-request-last-values-immediately-on-first-attempt
branch
from
4588f85 to
b58754a
Compare
facchinm
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not make sense to let the user wait until the timeout has passed (which is now even 30 seconds) long. Therefore the logic should trigger an immediate sync the first time this function is reached.