Improve reliability on connection loss #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…event getting stuck up in low_read/low_write (BearSSLClient::clientRead/clientWrite.
…ng topic subscription and request of last values. Otherwise it can happen that the connection is ripped out under you and you won't even notice.
|
Sure, I just uploaded a sketch that uses this PR. |
|
Memory usage change @ 5d3b90c
Click for full report table
Click for full report CSV |
|
Hi, Of course.
po 1. 3. 2021 v 8:51 odesílatel Alexander Entinger <[email protected]>
napsal:
… This fixes #86
<#86> and #221
<#221> (🙏).
@jcham <https://github.com/jcham> @IgorSchelle
<https://github.com/IgorSchelle> can you please test?
CC @eclipse1985 <https://github.com/eclipse1985> @zmoog
<https://github.com/zmoog> can please you test on your setup too?
------------------------------
You can view, comment on, or merge this pull request online at:
#233
Commit Summary
- Through usage of the dedicated flag _sslio_closing we do manage to
prevent getting stuck up in low_read/low_write
(BearSSLClient::clientRead/clientWrite.
- Also check if connection to the MQTT server is still established
during topic subscription and request of last values. Otherwise it can
happen that the connection is ripped out under you and you won't even
notice.
File Changes
- *M* src/ArduinoIoTCloudTCP.cpp
<https://github.com/arduino-libraries/ArduinoIoTCloud/pull/233/files#diff-3bce33c7c404e1b22d6ab7daf421336ad8789323054d9fd7856e76604c54cc13>
(16)
- *M* src/tls/BearSSLClient.cpp
<https://github.com/arduino-libraries/ArduinoIoTCloud/pull/233/files#diff-5c2bcd732fb7d8ab9467fdc4de94bd8f5df6c20175f7eaccae5b94a53daf290d>
(23)
- *M* src/tls/BearSSLClient.h
<https://github.com/arduino-libraries/ArduinoIoTCloud/pull/233/files#diff-2fa24e78bad89ba05efdfd2843d61519fb4116bec4a5430ac39a2fb46eb5408c>
(1)
Patch Links:
- https://github.com/arduino-libraries/ArduinoIoTCloud/pull/233.patch
- https://github.com/arduino-libraries/ArduinoIoTCloud/pull/233.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#233>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHGAHXN3V253OR2LO6467JDTBNBR7ANCNFSM4YMC4MEQ>
.
|
|
@aentinger deployed on my test weather station. |
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
- Coverage 95.27% 95.15% -0.12%
==========================================
Files 25 24 -1
Lines 889 867 -22
==========================================
- Hits 847 825 -22
Misses 42 42
Continue to review full report at Codecov.
|
|
Memory usage change @ 9852cd6
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #86 and #221 (:pray:). @jcham @IgorSchelle can you please test?
CC @eclipse1985 @zmoog can please you test on your setup too?