Skip to content

Only set hidden property OTA_CAP to true if the nina firmware version is >= 1.4.1 #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2020

Conversation

aentinger
Copy link
Contributor

@aentinger aentinger commented Aug 26, 2020

FYI @eclipse1985 🚀

@aentinger aentinger added the type: enhancement Proposed improvement label Aug 26, 2020
@aentinger aentinger self-assigned this Aug 26, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2020

Codecov Report

Merging #196 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #196   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files          25       25           
  Lines         889      889           
=======================================
  Hits          847      847           
  Misses         42       42           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36bde89...1734221. Read the comment docs.

@github-actions
Copy link

Memory usage change @ 3091f62

Board flash RAM for global variables
arduino-beta:mbed:envie_m4 0 - 0 0 - 0
arduino-beta:mbed:envie_m7 0 - 0 0 - 0
arduino:samd:mkr1000 0 - 0 0 - 0
arduino:samd:mkrgsm1400 0 - 0 0 - 0
arduino:samd:mkrnb1500 0 - 0 0 - 0
arduino:samd:mkrwan1300 0 - 0 0 - 0
arduino:samd:mkrwifi1010 🔺 0 - +8 0 - 0
arduino:samd:nano_33_iot 🔺 0 - +8 0 - 0
esp8266:esp8266:huzzah 0 - 0 0 - 0
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash
examples/ArduinoIoTCloud-Advanced
RAM for global variables
examples/ArduinoIoTCloud-Basic
flash
examples/ArduinoIoTCloud-Basic
RAM for global variables
examples/utility/ArduinoIoTCloud_Travis_CI
flash
examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables
examples/utility/Provisioning
flash
examples/utility/Provisioning
RAM for global variables
examples/utility/SelfProvisioning
flash
examples/utility/SelfProvisioning
RAM for global variables
arduino-beta:mbed:envie_m4 0 0 0 0 0 0 0 0
arduino-beta:mbed:envie_m7 0 0 0 0 0 0 0 0
arduino:samd:mkr1000 0 0 0 0 0 0 0 0
arduino:samd:mkrgsm1400 0 0 0 0 0 0 0 0
arduino:samd:mkrnb1500 0 0 0 0 0 0 0 0
arduino:samd:mkrwan1300 0 0 0 0 0 0
arduino:samd:mkrwifi1010 0 0 8 0 0 0 0 0 0 0
arduino:samd:nano_33_iot 8 0 8 0 8 0 0 0 0 0
esp8266:esp8266:huzzah 0 0 0 0 0 0
Click for full report CSV
Board,examples/ArduinoIoTCloud-Advanced<br>flash,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,examples/ArduinoIoTCloud-Basic<br>flash,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,examples/utility/Provisioning<br>flash,examples/utility/Provisioning<br>RAM for global variables,examples/utility/SelfProvisioning<br>flash,examples/utility/SelfProvisioning<br>RAM for global variables
arduino-beta:mbed:envie_m4,0,0,0,0,0,0,0,0
arduino-beta:mbed:envie_m7,0,0,0,0,0,0,0,0
arduino:samd:mkr1000,0,0,0,0,0,0,0,0
arduino:samd:mkrgsm1400,0,0,0,0,0,0,0,0
arduino:samd:mkrnb1500,0,0,0,0,0,0,0,0
arduino:samd:mkrwan1300,0,0,0,0,0,0,,
arduino:samd:mkrwifi1010,0,0,8,0,0,0,0,0,0,0
arduino:samd:nano_33_iot,8,0,8,0,8,0,0,0,0,0
esp8266:esp8266:huzzah,0,0,0,0,0,0,,,,

@aentinger aentinger merged commit 4376a5b into master Aug 27, 2020
@aentinger aentinger deleted the fix-nina-version-check branch August 27, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants