Skip to content

Removing stdin/stdout topic strings ... #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Conversation

aentinger
Copy link
Contributor

since we currently don't need those topics anymore (we might need them again once we reintegrate cloud serial but right now they just consume memory.

…se topics anymore (we might need them again once we reintegrate cloud serial but right now they just consume memory
@aentinger aentinger added the type: enhancement Proposed improvement label Aug 21, 2020
@aentinger aentinger self-assigned this Aug 21, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files          25       25           
  Lines         889      889           
=======================================
  Hits          847      847           
  Misses         42       42           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 714df56...d461404. Read the comment docs.

@github-actions
Copy link

Memory usage change @ d461404

Board flash RAM for global variables
arduino-beta:mbed:envie_m4 🔺 +80 - +152 💚 -24 - -24
arduino-beta:mbed:envie_m7 🔺 +80 - +96 💚 -24 - -24
arduino:samd:mkr1000 🔺 +120 - +160 💚 -24 - -24
arduino:samd:mkrgsm1400 🔺 +160 - +384 💚 -24 - -24
arduino:samd:mkrnb1500 🔺 +120 - +160 💚 -24 - -24
arduino:samd:mkrwan1300 🔺 +112 - +112 0 - 0
arduino:samd:mkrwifi1010 🔺 0 - +368 💚 -24 - 0
arduino:samd:nano_33_iot 🔺 0 - +360 💚 -24 - 0
esp8266:esp8266:huzzah 🔺 +136 - +152 🔺 +136 - +136
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash
examples/ArduinoIoTCloud-Advanced
RAM for global variables
examples/ArduinoIoTCloud-Basic
flash
examples/ArduinoIoTCloud-Basic
RAM for global variables
examples/utility/ArduinoIoTCloud_Travis_CI
flash
examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables
examples/utility/Provisioning
flash
examples/utility/Provisioning
RAM for global variables
examples/utility/SelfProvisioning
flash
examples/utility/SelfProvisioning
RAM for global variables
arduino-beta:mbed:envie_m4 88 -24 88 -24 80 -24 152 -24
arduino-beta:mbed:envie_m7 80 -24 88 -24 88 -24 96 -24
arduino:samd:mkr1000 128 -24 120 -24 128 -24 160 -24
arduino:samd:mkrgsm1400 384 -24 384 -24 384 -24 160 -24
arduino:samd:mkrnb1500 128 -24 120 -24 120 -24 160 -24
arduino:samd:mkrwan1300 112 0 112 0 112 0
arduino:samd:mkrwifi1010 368 -24 360 -24 368 -24 160 -24 0 0
arduino:samd:nano_33_iot 360 -24 360 -24 360 -24 160 -24 0 0
esp8266:esp8266:huzzah 152 136 136 136 136 136
Click for full report CSV
Board,examples/ArduinoIoTCloud-Advanced<br>flash,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,examples/ArduinoIoTCloud-Basic<br>flash,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,examples/utility/Provisioning<br>flash,examples/utility/Provisioning<br>RAM for global variables,examples/utility/SelfProvisioning<br>flash,examples/utility/SelfProvisioning<br>RAM for global variables
arduino-beta:mbed:envie_m4,88,-24,88,-24,80,-24,152,-24
arduino-beta:mbed:envie_m7,80,-24,88,-24,88,-24,96,-24
arduino:samd:mkr1000,128,-24,120,-24,128,-24,160,-24
arduino:samd:mkrgsm1400,384,-24,384,-24,384,-24,160,-24
arduino:samd:mkrnb1500,128,-24,120,-24,120,-24,160,-24
arduino:samd:mkrwan1300,112,0,112,0,112,0,,
arduino:samd:mkrwifi1010,368,-24,360,-24,368,-24,160,-24,0,0
arduino:samd:nano_33_iot,360,-24,360,-24,360,-24,160,-24,0,0
esp8266:esp8266:huzzah,152,136,136,136,136,136,,,,

@aentinger
Copy link
Contributor Author

Tested with MKR WiFi 1010 ✔️

@aentinger aentinger merged commit 2c8e67b into master Aug 21, 2020
@aentinger aentinger deleted the remove-stdin-stdout branch August 21, 2020 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants