Fix: Use sketch compile time if no connection is available for estimating system time. #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch, otherwise we might have an error scenario where no connection is available which would lead to a timestamp of 0 which would lead to the certificate being declared 'expired' and the device will be unable to connect to the server
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=======================================
Coverage 95.59% 95.59%
=======================================
Files 29 29
Lines 998 998
=======================================
Hits 954 954
Misses 44 44 Continue to review full report at Codecov.
|
|
Successfully tested on DEV with MRK WiFi 1010 ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the returned time is at least the compile time of the sketch, otherwise we might have an error scenario where no connection is available which would lead to a timestamp of 0 which would lead to the certificate being declared 'expired' and the device will be unable to connect to the server