Skip to content

Remove property OTA_STORAGE_TYPE ... #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Remove property OTA_STORAGE_TYPE ... #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/ArduinoIoTCloudTCP.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ ArduinoIoTCloudTCP::ArduinoIoTCloudTCP()
, _dataTopicIn("")
, _ota_topic_in{""}
#if OTA_ENABLED
, _ota_storage_type{static_cast<int>(OTAStorage::Type::NotAvailable)}
, _ota_error{static_cast<int>(OTAError::None)}
#endif /* OTA_ENABLED */
{
Expand Down Expand Up @@ -203,8 +202,6 @@ void ArduinoIoTCloudTCP::printDebugInfo()
#if OTA_ENABLED
void ArduinoIoTCloudTCP::setOTAStorage(OTAStorage & ota_storage)
{
_ota_storage_type = static_cast<int>(ota_storage.type());
addPropertyReal(_ota_storage_type, "OTA_STORAGE_TYPE", Permission::Read);
addPropertyReal(_ota_error, "OTA_ERROR", Permission::Read);
_ota_logic.setOTAStorage(ota_storage);
}
Expand Down
1 change: 0 additions & 1 deletion src/ArduinoIoTCloudTCP.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ class ArduinoIoTCloudTCP: public ArduinoIoTCloudClass

#if OTA_ENABLED
OTALogic _ota_logic;
int _ota_storage_type;
int _ota_error;
#endif /* OTA_ENABLED */

Expand Down
8 changes: 0 additions & 8 deletions src/utility/ota/OTAStorage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,6 @@ class OTAStorage
virtual ~OTAStorage() { }


enum class Type : int
{
NotAvailable = -1,
MKRMEM = 0,
MKRGSMFile = 2,
};

virtual Type type () = 0;
virtual bool init () = 0;
virtual bool open (char const * file_name) = 0;
virtual size_t write (uint8_t const * const buf, size_t const num_bytes) = 0;
Expand Down
1 change: 0 additions & 1 deletion src/utility/ota/OTAStorage_MKRGSM.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ class OTAStorage_MKRGSM : public OTAStorage
virtual ~OTAStorage_MKRGSM() { }


virtual Type type () override { return Type::MKRGSMFile; }
virtual bool init () override;
virtual bool open (char const * file_name) override;
virtual size_t write (uint8_t const * const buf, size_t const num_bytes) override;
Expand Down
1 change: 0 additions & 1 deletion src/utility/ota/OTAStorage_MKRMEM.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ class OTAStorage_MKRMEM : public OTAStorage
virtual ~OTAStorage_MKRMEM() { }


virtual Type type () override { return Type::MKRMEM; }
virtual bool init () override;
virtual bool open (char const * file_name) override;
virtual size_t write (uint8_t const * const buf, size_t const num_bytes) override;
Expand Down