Fix: Handle encoded CBOR message exceeding buffer size #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if a out-of-memory error occurs. If that's the case the CBOR encoding is completed until that property and the CBOR message is still sent with the next properties encoded on the next run of CBOREncoder::encode
… internal errors to the outside
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
==========================================
+ Coverage 95.43% 95.59% +0.15%
==========================================
Files 29 29
Lines 985 998 +13
==========================================
+ Hits 940 954 +14
+ Misses 45 44 -1
Continue to review full report at Codecov.
|
|
@manchoz this might be for you. |
aentinger
force-pushed
the
fix-cbor-msg-exceeds-buffer
branch
from
36e4bbc to
67548fe
Compare
…perties exceeds the capacity of the MQTT payload buffer
aentinger
force-pushed
the
fix-cbor-msg-exceeds-buffer
branch
from
67548fe to
b4cc977
Compare
|
Successfully tested on PROD with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the payload buffer for CBOR encoded messages has a size of 256 bytes. If the encoded cbor message is exceeding this max payload size then the whole message is discarded. This PR should fix this problem by encoding properties until the payload buffer is full and encoding the remaining properties on the next run of
CBOREncoder::encode.