Skip to content

Split ArduinoCloudThing into CBOREncoder and CBORDecoder and clean up superflous statements. #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 2, 2020

Conversation

aentinger
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2020

Codecov Report

Merging #150 into master will decrease coverage by 0.05%.
The diff coverage is 93.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   95.49%   95.43%   -0.06%     
==========================================
  Files          29       29              
  Lines         998      985      -13     
==========================================
- Hits          953      940      -13     
  Misses         45       45              
Impacted Files Coverage Δ
src/property/Property.h 90.47% <ø> (ø)
src/cbor/CBOREncoder.cpp 80.00% <80.00%> (ø)
src/property/Property.cpp 86.74% <90.62%> (+0.58%) ⬆️
src/cbor/CBORDecoder.cpp 96.22% <96.61%> (ø)
src/property/PropertyContainer.cpp 90.76% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de0d21c...7548be5. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Memory usage change @7548be5daaa1b6a7dbc8db64dd3c025b8d88b498

FQBN Flash Usage RAM For Global Variables
arduino:samd:mkr1000 🔺 +24 💚 -40
arduino:samd:mkrgsm1400 🔺 +24 💚 -40
arduino:samd:mkrnb1500 🔺 +24 💚 -40
arduino:samd:mkrwan1300 🔺 +56 💚 -40
arduino:samd:mkrwifi1010 🔺 +24 💚 -40
arduino:samd:nano_33_iot 🔺 +24 💚 -40
esp8266:esp8266:huzzah 🔺 +176 💚 -40

@aentinger
Copy link
Contributor Author

Successfully tested on PROD with:

  • Nano 33 IoT ✔️
  • MKR WiFi 1010 ✔️
  • MKR 1000 ✔️
  • MKR GSM 1400 ✔️
  • ESP8266 ✔️
  • MKR WAN 1310 ✔️

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jul 2, 2020
@aentinger aentinger merged commit 0e4aa69 into master Jul 2, 2020
@aentinger aentinger deleted the cbor-encoder branch July 2, 2020 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants