Skip to content

Deprecate old c style functions for adding properties in favour of composition #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2020

Conversation

aentinger
Copy link
Contributor

This PR deprecates this property initialisation approach

ArduinoCloud.addProperty(seconds, READ, ON_CHANGE, onSecondsChange);

in favour of

  ArduinoCloud.addProperty(seconds, Permission::Read).publishOnChange();

…e shortened property, name, permission parameters and returninga reference to the property for further configuration via concatenation of methods, such as .publishOnChange,etc.
@aentinger aentinger self-assigned this Jun 10, 2020
@aentinger aentinger added the type: enhancement Proposed improvement label Jun 10, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #139 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files          29       29           
  Lines         995      995           
=======================================
  Hits          951      951           
  Misses         44       44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07bb78f...83f2c8e. Read the comment docs.

@github-actions
Copy link

Memory usage change @83f2c8e9de8c5654a5bdddd1de09b5b5184d19fa

FQBN Flash Usage RAM For Global Variables
arduino:samd:mkr1000 0 0
arduino:samd:mkrgsm1400 0 0
arduino:samd:mkrnb1500 0 0
arduino:samd:mkrwan1300 0 0
arduino:samd:mkrwifi1010 0 0
arduino:samd:nano_33_iot 0 0
esp8266:esp8266:huzzah 0 0

@aentinger aentinger merged commit cae230c into master Jun 10, 2020
@aentinger aentinger deleted the deprecate-C-style-addProperty-Func branch June 10, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants