-
Notifications
You must be signed in to change notification settings - Fork 80
Allow an optional encoding of the timestamp in the CBOR message #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
==========================================
- Coverage 96.15% 95.55% -0.61%
==========================================
Files 30 29 -1
Lines 988 989 +1
==========================================
- Hits 950 945 -5
- Misses 38 44 +6
Continue to review full report at Codecov.
|
5b2ce06
to
4959e2b
Compare
Successfully tested on PROD with
|
Memory usage change @4959e2b08c24e22de72a9ee5ce26f37de7a48c3e
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enable the encoding of the timestamp you can've got to call
encodeTimestamp()
when adding the property to the cloud withinthing_properties.h
.In order to set the timestamp of the property you call
This is the resulting CBOR
[{0: "seconds", 2: 45, 6: 45}]
@zmoog @manchoz 👋