Extracting property container functionality #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
=======================================
Coverage 97.23% 97.23%
=======================================
Files 28 30 +2
Lines 975 976 +1
=======================================
+ Hits 948 949 +1
Misses 27 27
Continue to review full report at Codecov.
|
|
Memory usage change @08cde49432f85da7f51fc4b42958be52fba79076
|
…l property related code to subfolder property
|
Successfully tested on PROD with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the "container" functionality for holding all the properties has been exercised by the class ArduinoCloudThing which leads to this class doing business logic, cbor encoding/decoding and container services. In order to clean up the interfaces and make the code more understandable and extendable it is desirable to have only one purpose per class (SRP).