Make HttpClient::responseBody more robust

[sandeepmistry]

Return invalidated String if memory allocation fails or content length does not match body data length. Also, use timed reads to support responses without a content length.

In order to perform the following check, a patched version of String is needed (see arduino/ArduinoCore-samd#153 and arduino/Arduino#5127):

String response;
int statusCode = 0;

// ...

void loop() {
  client.get("/");

  statusCode = client.responseStatusCode();
  response = client.responseBody();

  if (response) {
    Serial.print("Response: ");
    Serial.println(response);
  } else {
    Serial.println("Reading response failed");
  }
}

[zonque]

Hmm, I don't think the library can rely on behavior of a patched core class.

[zonque]

What's the rationale of this, does it fix a bug?

[sandeepmistry]

Yes, it was to reset state when a HttpClient is reused.

[sandeepmistry]

@zonque

Hmm, I don't think the library can rely on behavior of a patched core class.

For cores without the fix something like this can be used:

String response = client.responseBody();
if (httpClient.contentLength() > response.length()) {
  // reading response body failed
} else {
  Serial.print("Response: ");
  Serial.println(response);
}