Fix incorrect return value, resulting in compilation error, being there for 8 years! #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error in question:
Now this one really pissed me off. It is not the error itself, but a fact that this was ignored from the first time it was uploaded to GitHub:
...AND ESP team was knowing about it and no one give a single bit of effort porting that change into mainstream. Despite hundreds of people using arduino ecosystem and this lib.
It looks even more retarded , that avr-gcc let it pass trough.
Notes for future: please add CI here with grain of static analysis tool. It is not that hard.