Skip to content

Adjust spell check tool configuration to avoid false positive #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Adjust spell check tool configuration to avoid false positive #31

merged 1 commit into from
Jun 27, 2023

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jun 27, 2023

The repository's CI system includes a check for commonly misspelled words.

The latest version of the codespell tool dependency used for this spell check is always used. This means that the results of the spell check can change as new versions of the tool are released. The recent codespell release introduced a false positive result:

https://github.com/arduino-libraries/ArduinoGraphics/actions/runs/5387324234/jobs/9778490628#step:4:17

Error: ./examples/ASCIIDraw/ASCIIDraw.ino:29: mis ==> miss, mist

This is corrected by adding the word to the ignore list in the codespell configuration file.

The repository's CI system includes a check for commonly misspelled words.

The latest version of the codespell tool dependency used for this spell check is always used. This means that the
results of the spell check can change as new versions of the tool are released. The recent codespell release introduced
a false positive result. This is corrected by adding the word to the ignore list in the codespell configuration file.
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: infrastructure Related to project infrastructure labels Jun 27, 2023
@per1234 per1234 self-assigned this Jun 27, 2023
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you @per1234 🚀

@aentinger aentinger merged commit 2eaeeb4 into arduino-libraries:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants