Adding HMAC and nonce functionality for ATECC608 #45

RLeclair · 2022-10-21T16:19:36Z

Addressing issue #42

Adding nonce functionality

Exposing challenge private function which does nonce

Adding HMAC functionality

Did not implement for 508
beginHMAC: SHA opcode, uses HMAC begin mode.
updateHMAC: implements while loop for processing data of different lengths.
endHMAC: in 608 does not differ from endSHA256.

Adding HMAC and nonce example

Simple example to do an HMAC 256 operation using nonce and HMAC (0xFFFF is keySlot for TempKey)

CLAassistant · 2022-10-21T16:19:41Z

All committers have signed the CLA.

github-actions · 2022-10-21T16:37:55Z

Memory usage change @ 7a9b7c2

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m7	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:megaavr:uno2018	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrgsm1400	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrnb1500	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrvidor4000	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1310	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:nano_33_iot	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/ECCX08HMAC flash	%	examples/ECCX08HMAC RAM for global variables	%
arduino:mbed:envie_m7	N/A	N/A	N/A	N/A
arduino:mbed_nano:nanorp2040connect	N/A	N/A	N/A	N/A
arduino:megaavr:uno2018	N/A	N/A	N/A	N/A
arduino:samd:mkr1000	N/A	N/A	N/A	N/A
arduino:samd:mkrgsm1400	N/A	N/A	N/A	N/A
arduino:samd:mkrnb1500	N/A	N/A	N/A	N/A
arduino:samd:mkrvidor4000	N/A	N/A	N/A	N/A
arduino:samd:mkrwan1300	N/A	N/A	N/A	N/A
arduino:samd:mkrwan1310	N/A	N/A	N/A	N/A
arduino:samd:mkrwifi1010	N/A	N/A	N/A	N/A
arduino:samd:nano_33_iot	N/A	N/A	N/A	N/A

Click for full report CSV

Board,examples/ECCX08HMAC<br>flash,%,examples/ECCX08HMAC<br>RAM for global variables,%,examples/ECCX08RandomNumber<br>flash,%,examples/ECCX08RandomNumber<br>RAM for global variables,%,examples/Tools/ECCX08CSR<br>flash,%,examples/Tools/ECCX08CSR<br>RAM for global variables,%,examples/Tools/ECCX08JWSPublicKey<br>flash,%,examples/Tools/ECCX08JWSPublicKey<br>RAM for global variables,%,examples/Tools/ECCX08SelfSignedCert<br>flash,%,examples/Tools/ECCX08SelfSignedCert<br>RAM for global variables,%
arduino:mbed:envie_m7,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:megaavr:uno2018,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrgsm1400,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrnb1500,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrvidor4000,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1300,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1310,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

per1234 · 2022-11-03T17:58:33Z

Hi @RLeclair. Thanks so much for your pull request!

It looks like you have not yet signed the contributor license agreement, which we require of all contributors. Would you mind taking care of that so it doesn't act as a blocker on merging this PR?

It can be signed here:

https://cla-assistant.io/arduino-libraries/ArduinoECCX08?pullRequest=45

Please let me know if you have any questions or concerns.

RLeclair · 2022-11-16T17:06:16Z

Hi @per1234 just signed the contributor license agreement, apologies for the delay!

RLeclair · 2022-11-17T18:52:54Z

Hi @per1234, is there anything else needed for merging this PR? Let me know, thanks!

examples/ECCX08HMAC/ECCX08HMAC.ino

src/ECCX08.cpp

Co-authored-by: Dane Walton <[email protected]>

github-actions · 2022-11-18T18:43:39Z

Memory usage change @ 4562d7c

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m7	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:megaavr:uno2018	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrgsm1400	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrnb1500	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrvidor4000	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1310	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:nano_33_iot	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/ECCX08HMAC flash	%	examples/ECCX08HMAC RAM for global variables	%
arduino:mbed:envie_m7	N/A	N/A	N/A	N/A
arduino:mbed_nano:nanorp2040connect	N/A	N/A	N/A	N/A
arduino:megaavr:uno2018	N/A	N/A	N/A	N/A
arduino:samd:mkr1000	N/A	N/A	N/A	N/A
arduino:samd:mkrgsm1400	N/A	N/A	N/A	N/A
arduino:samd:mkrnb1500	N/A	N/A	N/A	N/A
arduino:samd:mkrvidor4000	N/A	N/A	N/A	N/A
arduino:samd:mkrwan1300	N/A	N/A	N/A	N/A
arduino:samd:mkrwan1310	N/A	N/A	N/A	N/A
arduino:samd:mkrwifi1010	N/A	N/A	N/A	N/A
arduino:samd:nano_33_iot	N/A	N/A	N/A	N/A

Click for full report CSV

Board,examples/ECCX08HMAC<br>flash,%,examples/ECCX08HMAC<br>RAM for global variables,%,examples/ECCX08RandomNumber<br>flash,%,examples/ECCX08RandomNumber<br>RAM for global variables,%,examples/Tools/ECCX08CSR<br>flash,%,examples/Tools/ECCX08CSR<br>RAM for global variables,%,examples/Tools/ECCX08JWSPublicKey<br>flash,%,examples/Tools/ECCX08JWSPublicKey<br>RAM for global variables,%,examples/Tools/ECCX08SelfSignedCert<br>flash,%,examples/Tools/ECCX08SelfSignedCert<br>RAM for global variables,%
arduino:mbed:envie_m7,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:megaavr:uno2018,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrgsm1400,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrnb1500,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrvidor4000,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1300,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1310,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

github-actions · 2022-11-18T19:15:35Z

Memory usage change @ eb93d9d

Board	flash	%	RAM for global variables	%
arduino:mbed:envie_m7	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:mbed_nano:nanorp2040connect	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:megaavr:uno2018	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrgsm1400	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrnb1500	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrvidor4000	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1300	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1310	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:nano_33_iot	0 - 0	0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/ECCX08HMAC flash	%	examples/ECCX08HMAC RAM for global variables	%
arduino:mbed:envie_m7	N/A	N/A	N/A	N/A
arduino:mbed_nano:nanorp2040connect	N/A	N/A	N/A	N/A
arduino:megaavr:uno2018	N/A	N/A	N/A	N/A
arduino:samd:mkr1000	N/A	N/A	N/A	N/A
arduino:samd:mkrgsm1400	N/A	N/A	N/A	N/A
arduino:samd:mkrnb1500	N/A	N/A	N/A	N/A
arduino:samd:mkrvidor4000	N/A	N/A	N/A	N/A
arduino:samd:mkrwan1300	N/A	N/A	N/A	N/A
arduino:samd:mkrwan1310	N/A	N/A	N/A	N/A
arduino:samd:mkrwifi1010	N/A	N/A	N/A	N/A
arduino:samd:nano_33_iot	N/A	N/A	N/A	N/A

Click for full report CSV

Board,examples/ECCX08HMAC<br>flash,%,examples/ECCX08HMAC<br>RAM for global variables,%,examples/ECCX08RandomNumber<br>flash,%,examples/ECCX08RandomNumber<br>RAM for global variables,%,examples/Tools/ECCX08CSR<br>flash,%,examples/Tools/ECCX08CSR<br>RAM for global variables,%,examples/Tools/ECCX08JWSPublicKey<br>flash,%,examples/Tools/ECCX08JWSPublicKey<br>RAM for global variables,%,examples/Tools/ECCX08SelfSignedCert<br>flash,%,examples/Tools/ECCX08SelfSignedCert<br>RAM for global variables,%
arduino:mbed:envie_m7,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:megaavr:uno2018,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrgsm1400,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrnb1500,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrvidor4000,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1300,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1310,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,N/A,N/A,N/A,N/A,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

RLeclair · 2022-11-28T21:05:35Z

Hi @facchinm, thanks for reviewing the PR, wanted to know if there is anything left needed to merge this PR?

facchinm · 2022-12-01T17:04:33Z

LGTM! Squashing and merging!

RLeclair · 2022-12-01T23:14:59Z

@facchinm I saw that the latest release was in March, is there a planned release date for 1.3.7? Thanks for all the help!

facchinm · 2022-12-02T08:10:24Z

Releasing now 😉

RLeclair added 5 commits October 20, 2022 15:39

Adding HMAC functionality.

0fe299d

Minor bug fix

a36a841

Adding HMAC and nonce example

bca4e13

Adding 508 check

0534372

Adding newline

7a9b7c2

per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Oct 21, 2022

facchinm approved these changes Nov 2, 2022

View reviewed changes

per1234 added the status: blocked Progress on this prevented by an external cause label Nov 3, 2022

per1234 removed the status: blocked Progress on this prevented by an external cause label Nov 16, 2022

danewalton-msft reviewed Nov 17, 2022

View reviewed changes

Apply suggestions from code review

4562d7c

Co-authored-by: Dane Walton <[email protected]>

RLeclair added 2 commits November 18, 2022 10:47

Addressing comments

199703b

Quick fix

eb93d9d

facchinm merged commit 82ec8c1 into arduino-libraries:master Dec 1, 2022

per1234 mentioned this pull request Dec 1, 2022

HMAC SHA256 hashing #42

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding HMAC and nonce functionality for ATECC608 #45

Adding HMAC and nonce functionality for ATECC608 #45

RLeclair commented Oct 21, 2022

CLAassistant commented Oct 21, 2022 •

edited

Loading

github-actions bot commented Oct 21, 2022

per1234 commented Nov 3, 2022

RLeclair commented Nov 16, 2022

RLeclair commented Nov 17, 2022

github-actions bot commented Nov 18, 2022

github-actions bot commented Nov 18, 2022

RLeclair commented Nov 28, 2022

facchinm commented Dec 1, 2022

RLeclair commented Dec 1, 2022

facchinm commented Dec 2, 2022

Adding HMAC and nonce functionality for ATECC608 #45

Adding HMAC and nonce functionality for ATECC608 #45

Conversation

RLeclair commented Oct 21, 2022

CLAassistant commented Oct 21, 2022 • edited Loading

github-actions bot commented Oct 21, 2022

per1234 commented Nov 3, 2022

RLeclair commented Nov 16, 2022

RLeclair commented Nov 17, 2022

github-actions bot commented Nov 18, 2022

github-actions bot commented Nov 18, 2022

RLeclair commented Nov 28, 2022

facchinm commented Dec 1, 2022

RLeclair commented Dec 1, 2022

facchinm commented Dec 2, 2022

CLAassistant commented Oct 21, 2022 •

edited

Loading