This repository was archived by the owner on Aug 18, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
LoRa support #48
Merged
Merged
LoRa support #48
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
aa97693
First version of LoRa adapter
mirkokurt 55fe5e5
Fix encoding of property identifier
mirkokurt fcc5419
Light payload management
mirkokurt 4beff82
Unit test updated
mirkokurt 081a5f6
Added property identifier to addPropertyReal method
mirkokurt 7fbfe1f
Fix Astyle formatting
mirkokurt 2b84cd1
Fix unit tests
mirkokurt e4140c3
Added comments to the code
mirkokurt f083971
Restored the code of getTimestamp() method
mirkokurt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was the content of this function deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now the code is restored.
Hi @lxrobotics, I added many comments in the code to help programmers understanding how the library encode and decode the cbor messages when the option of using "light payloads" has been activated. I also updated the PR description to better explain the purpose of the implementation.
Regarding the commit
Fix unit tests
, there are two kind of fixes in the commit:the first kind is a logic fix:
eg:
-thing.addPropertyReal(color_test, "test", Permission::ReadWrite);
+thing.addPropertyReal(color_test, "test", Permission::ReadWrite, 1);
the addPropertyReal method was invoked without an identifier assigned to the property. So the test was not well written.
The second kind is a fix in the comment that was previously wrong in respect of the byte array.
eg:
-/* [{0: "test", 4: false}] = 81 A2 00 01 04 F4 /
+/ [{0: 1, 4: false}] = 81 A2 00 01 04 F4 */
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By mistake. Now the code is restored.