Skip to content

Add --pico-family parameter #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

infiniteloop5
Copy link
Contributor

Compilation of the pico-blink example failed with the following error:

usage: macho2uf2.py [-h] --base-address BASE_ADDRESS --segments SEGMENTS --pico-family PICO_FAMILY input output
macho2uf2.py: error: the following arguments are required: --pico-family

Looks like the --pico-family parameter became mandatory.

This PR adds a PICO_FAMILY variable near the top of the build script, with a comment pointing out the two possible values (according to the source code of macho2uf2.py).
It then then sets --pico-family to this variable.

Maybe it makes sense to set up some kind of CI to catch these kind of build errors automatically.

@iCMDdev
Copy link
Contributor

iCMDdev commented Sep 16, 2024

I think you could also change the target architecture from armv6m to armv7m based on this for RP2350 boards, even though the latter is backwards compatible with the former (and should be fine as long as the swift binary isn't being linked to armv7m libs - this was the case with the Pico SDK examples, but was fixed in the last commit).

Maybe the slightly improved instruction set will bring some (perhaps tiny) performance benefits? 😁

@rauhul
Copy link
Collaborator

rauhul commented Sep 26, 2024

Sorry I missed this (was out sick) I think we can merge this as is!

@rauhul rauhul merged commit e393824 into apple:main Sep 26, 2024
@infiniteloop5 infiniteloop5 deleted the feature/add-pico-family-parameter branch October 11, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants