Skip to content

esp: add march and mabi flags for all riscv chips #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

erhankur
Copy link
Contributor

@erhankur erhankur commented Jun 28, 2024

A better solution could be to get the March and Mabi flags from the idf toolchain-clang-<target>.cmake file. However, for now, the IDF build uses the GCC toolchain instead of Clang. I would like to test the Clang build and then modify the related parts.

Closes #19

@rauhul
Copy link
Collaborator

rauhul commented Jun 28, 2024

I'm going to sign Kuba up to review this one

@rauhul rauhul added the enhancement New feature or request label Jun 28, 2024
@erhankur erhankur force-pushed the esp_cmake_changes branch 3 times, most recently from 8f9c590 to 991a9b3 Compare June 29, 2024 08:33
Copy link
Collaborator

@rauhul rauhul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small questions

@erhankur erhankur force-pushed the esp_cmake_changes branch from 991a9b3 to ae98659 Compare July 3, 2024 08:05
Copy link
Collaborator

@rauhul rauhul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements! Can we open an issue to change this code to extract the flags from the idf toolchain-clang-.cmake file?

@rauhul rauhul merged commit ab9a24c into apple:main Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esp32-p4 support - march=rv32imafc
3 participants