Doc update2 #143
Merged
Doc update2 #143
+22
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauhul
reviewed
May 24, 2025
| @@ -16,7 +16,7 @@ Implementation status of compiler and language features in Embedded Swift, compa | |||
| | Metatypes | No, currently only allowed as unused arguments (type hints) | | |||
| | Untyped throwing | No, intentionally unsupported long-term (typed throwing should be used instead) | | |||
| | Weak references, unowned references | No | | |||
| | Non-final generic class methods | No, intentionally unsupported long-term, see <[Embedded Swift -- Non-final generic methods](NonFinalGenericMethods.md)>| | |||
There was a problem hiding this comment.
can we use a docc style link here?
rauhul
reviewed
May 24, 2025
| @@ -27,4 +27,4 @@ Note that there are no behavior changes in Embedded Swift compared to full Swift | |||
|
|
|||
| ## Further resources | |||
|
|
|||
| The above lists are describing features that are removed from Embedded Swift *by design*. Since Embedded Swift is currently an experimental preview, there might also be features that are not yet implemented. See the in-development status at [Embedded Swift -- Status](EmbeddedSwiftStatus.md). | |||
There was a problem hiding this comment.
same note about docc style link
There was a problem hiding this comment.
I kept the same link type as before, just fixing the name so it points to the right place.
I checked if I could specify a name when using the <doc: > construct but did not find anything in the doc.
I believe in the name would automatically be the name of the target document, which I'm fine with.
There was a problem hiding this comment.
I did change the link, it indeed looks cleaner
kubamracek
approved these changes
May 29, 2025
|
Thanks, @ebariaux, these are all great changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly fixes for typos and broken links