Skip to content

Improve nrfx-blink-sdk example to automatically get Zephyr defines and show using nrfutil instead of nrfjprog #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xtremekforever
Copy link
Contributor

@kubamracek I figured out how to get the Zephyr defines programmatically in CMakeLists.txt so that they don't have to be hardcoded. Please have a look!

  1. Instead of manually setting the compiler defines that Zephyr provides (-D__ZEPHYR__=1, -DKERNEL, etc), we dynamically grab them from the zephyr_interface INTERFACE_COMPILE_DEFINITIONS and set -Xcc flags for Swift compilation instead.
  2. The nRF Command Line Tools are deprecated and have been replaced by the nRF Util tool instead. As such, I've updated the README.md to show using nrfutil instead of nrfjprog.

@rauhul I have also been working on an Integration with Zephyr document for this repo, but still in progress. I'm hoping to have something soon in the next few weeks that we can look at.

@rauhul
Copy link
Collaborator

rauhul commented May 13, 2025

Ignore the "Update Swift Version / Create or update PR (pull_request)" failure. That workflow shouldn't run on PRs, the fix is here: #131

@rauhul
Copy link
Collaborator

rauhul commented May 16, 2025

@kubamracek can you review this one?

@rauhul
Copy link
Collaborator

rauhul commented May 17, 2025

@xtremekforever it looks like the zephyr build is broken due to an upstream change, and im not sure how to resolve it. is this something you could look into?

@rauhul
Copy link
Collaborator

rauhul commented May 17, 2025

I'm disabling CI for Zephyr here to unblock other PRs: #136

@xtremekforever
Copy link
Contributor Author

@xtremekforever it looks like the zephyr build is broken due to an upstream change, and im not sure how to resolve it. is this something you could look into?

Is it from a Zephyr change or a Swift change? I've run into issues when checking out newer Zephyr versions before, so I ended up locking it to v4.1 for all my workspaces.

@rauhul
Copy link
Collaborator

rauhul commented May 17, 2025

@xtremekforever it looks like the zephyr build is broken due to an upstream change, and im not sure how to resolve it. is this something you could look into?

Is it from a Zephyr change or a Swift change? I've run into issues when checking out newer Zephyr versions before, so I ended up locking it to v4.1 for all my workspaces.

Seems to be a zephyr change, do you think you could help us pin the zephyr version(s) used in this repo? I'm not familiar with all the places pins are needed.

@rauhul rauhul force-pushed the feature/improve-nrfx-blink-sdk-example branch from 85c278d to b45e395 Compare May 17, 2025 21:18
@xtremekforever
Copy link
Contributor Author

Sure @rauhul let me have a look tonight. If I find a solution I can PR separately to this repo to fix the issue.

@rauhul rauhul force-pushed the feature/improve-nrfx-blink-sdk-example branch from aa26195 to 5eeeac3 Compare May 18, 2025 16:32
@rauhul rauhul merged commit 7e1f25f into apple:main May 18, 2025
20 checks passed
@xtremekforever xtremekforever deleted the feature/improve-nrfx-blink-sdk-example branch May 18, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants