Move generated registers into discrete modules #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the stm32 examples to put generated register interfaces into their own module. This improves build performance because the swiftmodule containing the generated registers doesn't need to be rebuilt when the primary application changes. Ideally these registers would be generated using the SVD2SwiftPlugin instead of directly checked into the repo, however there is a huge build time cost to this because SwiftPM has separate build graphs for plugins vs the primary build. This results in 2 copies of swift-syntax getting built which inflates build time to 5+ minutes. Worse, SwiftPM randomly triggers rebuilds of swift-syntax in the plugin graph making using the plugin effectively impossible.
rauhul
force-pushed
the
move-registers-to-module
branch
from
df796b9 to
dbdb91f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the stm32 examples to put generated register interfaces into their own module. This improves build performance because the swiftmodule containing the generated registers doesn't need to be rebuilt when the primary application changes.
Ideally these registers would be generated using the SVD2SwiftPlugin instead of directly checked into the repo, however there is a huge build time cost to this because SwiftPM has separate build graphs for plugins vs the primary build. This results in 2 copies of swift-syntax getting built which inflates build time to 5+ minutes. Worse, SwiftPM randomly triggers rebuilds of swift-syntax in the plugin graph making using the plugin effectively impossible.