Skip to content

Added pico-w blink example #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

yochidros
Copy link
Contributor

Hi! I tried using the pico-blink-sdk with a Pico-W, but it didn't work because the LED module is on the wireless chip. For the Pico-W, the pico-sdk doesn't define PICO_DEFAULT_LED_PIN; instead, it uses CYW43_WL_GPIO_LED_PIN.
Ref: Pico-SDK

I also tried using CYW43_WL_GPIO_LED_PIN to make the Pico-W blink. By linking several necessary modules, I was able to get it working successfully!

I thought this example might be useful to other developers, so I added it!

I recently close PR #6, but @kubamracek commented #6 (comment). I appreciate that. I added pico-w-blink-sdk entry into the top-level README.

//
// This source file is part of the Swift open source project
//
// Copyright (c) 2023 Apple Inc. and the Swift project authors.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the year to 2024 for the files added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rauhul I fixed it. ba8f899

@kubamracek
Copy link
Collaborator

Could you scale down the photo of the board? (it’s now an 8 MB jpeg)

@yochidros
Copy link
Contributor Author

@kubamracek
I scaled down the photo 8MB -> 691KB!!

@yochidros yochidros requested a review from rauhul May 14, 2024 01:59
@kubamracek
Copy link
Collaborator

Looks great, and I confirmed it works on a Pico W. Thanks!!!

@unnamedd
Copy link

I really thank you all for the hard work done in this repo and also in this repo! I do have some Picos at home and I really want to get an extra time for playing with it.

Thanks a lot guys! You are awesome!

@rauhul
Copy link
Collaborator

rauhul commented May 14, 2024

Looks great, and I confirmed it works on a Pico W. Thanks!!!

I'm out of vacation right now and won't be able to repro, feel free to merge this 😃

@yochidros
Copy link
Contributor Author

@kubamracek @rauhul
thank you for review.
I can't merge this PR. so, please could you merge it when you have time.🙏

@kubamracek kubamracek merged commit 05b79f9 into apple:main May 16, 2024
@kubamracek
Copy link
Collaborator

Thanks @yochidros, this is a great contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants