Publish Java client through Jitpack #1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,7 @@ apply plugin: 'maven-publish' | |||
| import org.apache.tools.ant.filters.* | |||
|
|
|||
| group 'io.appium' | |||
| version '6.1.0' | |||
| version '6.1.1-SNAPSHOT' | |||
There was a problem hiding this comment.
don't we call it BETA1?
There was a problem hiding this comment.
Ideally we used to call as 'SNAPSHOT' in maven world before we release either beta or major version.
README.md
Outdated
|
|
||
| ``` | ||
| dependencies { | ||
| implementation 'com.github.User:Repo:Tag' |
There was a problem hiding this comment.
can we set the data for java client in this example?
There was a problem hiding this comment.
Sure will update
|
I can observe errors in the logs under https://jitpack.io/#appium/java-client. Shouldn't these logs be green? |
|
yah it should be green, build is failing because it's not skipping the sign archives |
|
@mykola-mokhnach It wont be green until unless it is merged or atleast should be a branch in upstream to run. Check here |
|
Here is the build logs from jitpack |
|
Ok, I believe you know better |
mykola-mokhnach
approved these changes
Aug 25, 2018
jlipps
approved these changes
Aug 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Publish Java client through Jitpack
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that apply@mykola-mokhnach @jlipps This PR will allow us to publish java client through jitpack. This will unblock users to use latest commit even before its available in maven central.