Add support for MySQL auto_increment offset #950
Conversation
ehoeve
changed the title
src/ast/helpers/stmt_create_table.rs
Outdated
| @@ -66,6 +66,7 @@ pub struct CreateTableBuilder { | |||
| pub clone: Option<ObjectName>, | |||
| pub engine: Option<String>, | |||
| pub comment: Option<String>, | |||
| pub autoincrement_offset: Option<u32>, | |||
There was a problem hiding this comment.
is there any reason to use a different style than the original auto_increment? I wonder if you considered:
| pub autoincrement_offset: Option<u32>, | |
| pub auto_increment_offset: Option<u32>, |
?
If so can you explain why you chose this way?
I was thinking that following the exisiting convention would make the relevant code / field easier to search for (aka you can search for auto_increment in the code to see how auto_increment in SQL would be parsed.
There was a problem hiding this comment.
@alamb Thanks for the feedback.
No specific reason, your suggestion of more closely following convention is a better option I think, so I updated the PR
src/parser/mod.rs
Outdated
| @@ -3550,6 +3550,17 @@ impl<'a> Parser<'a> { | |||
| None | |||
| }; | |||
|
|
|||
| let autoincrement_offset = if self.parse_keyword(Keyword::AUTO_INCREMENT) { | |||
There was a problem hiding this comment.
https://dev.mysql.com/doc/refman/8.0/en/create-table.html
I got super confused for a moment because AUTO_INCREMENT can occur either as part of the table options (as this PR correctly does)
table_options:
table_option [[,] table_option] ...
table_option: {
AUTOEXTEND_SIZE [=] value
| AUTO_INCREMENT [=] value
| AVG_ROW_LENGTH [=] value
...
Or also as part of the column definition
column_definition: {
data_type [NOT NULL | NULL] [DEFAULT {literal | (expr)} ]
[VISIBLE | INVISIBLE]
[AUTO_INCREMENT] [UNIQUE [KEY]] [[PRIMARY] KEY]
...
Which SQLParser already handles
https://github.com/sqlparser-rs/sqlparser-rs/blob/41e47cc0136c705a3335b1504d50ae8b22711b86/src/ast/ddl.rs#L587
|
Thanks @ehoeve |
This should also fix #920.