Skip to content

Support EXISTS subqueries #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Support EXISTS subqueries #90

merged 1 commit into from
Jun 3, 2019

Conversation

benesch
Copy link
Contributor

@benesch benesch commented Jun 3, 2019

No description provided.

@benesch benesch requested a review from nickolay June 3, 2019 02:33
@coveralls
Copy link

Pull Request Test Coverage Report for Build 238

  • 26 of 29 (89.66%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.877%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_common.rs 17 20 85.0%
Totals Coverage Status
Change from base Build 234: 0.0%
Covered Lines: 1465
Relevant Lines: 1630

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 3, 2019

Pull Request Test Coverage Report for Build 258

  • 30 of 32 (93.75%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 90.579%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_common.rs 22 24 91.67%
Files with Coverage Reduction New Missed Lines %
tests/sqlparser_common.rs 4 91.43%
Totals Coverage Status
Change from base Build 256: 0.01%
Covered Lines: 3394
Relevant Lines: 3747

💛 - Coveralls

@benesch benesch mentioned this pull request Jun 3, 2019
Copy link
Contributor

@nickolay nickolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'm assuming NOT EXISTS() will parse correctly with unary NOT, unsure if it deserves a test of its own.

This fixes the last remaining part of #5, thanks!

@benesch
Copy link
Contributor Author

benesch commented Jun 3, 2019

I'm assuming NOT EXISTS() will parse correctly with unary NOT, unsure if it deserves a test of its own.

Yep! I added a test just to be sure.

This fixes the last remaining part of #5, thanks!

Oh, nice. I've updated the commit message to close out #5 when this merges.

@benesch benesch merged commit 7aff707 into apache:master Jun 3, 2019
@benesch benesch deleted the exists branch June 3, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants