Skip to content

Support identifiers beginning with digits in MySQL #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2023
Merged

Support identifiers beginning with digits in MySQL #856

merged 1 commit into from
Apr 26, 2023

Conversation

AviRaboah
Copy link
Contributor

Closes #804.

ankrgyl
ankrgyl reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@ankrgyl ankrgyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! The code lgtm. @alamb on to you

alamb
alamb reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AviRaboah and @ankrgyl -- the only other thing I suggest is a negative case for the exponent case

For example, can we add a test case to make sure 123e4 can not be used as an identifier? (at least that is my understanding of the limitation)

@coveralls
Copy link

coveralls commented Apr 24, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4791016757

  • 65 of 66 (98.48%) changed or added relevant lines in 2 files are covered.
  • 59 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.4%) to 85.874%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/tokenizer.rs 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
src/tokenizer.rs 1 89.11%
src/ast/helpers/stmt_create_table.rs 15 84.02%
src/parser.rs 43 81.88%
Totals Coverage Status
Change from base Build 4681944467: -0.4%
Covered Lines: 13769
Relevant Lines: 16034
💛 - Coveralls

@AviRaboah
Copy link
Contributor Author

AviRaboah commented Apr 24, 2023 •
edited
Loading

Thank you @AviRaboah and @ankrgyl -- the only other thing I suggest is a negative case for the exponent case

For example, can we add a test case to make sure 123e4 can not be used as an identifier? (at least that is my understanding of the limitation)

Thank you @alamb i'll add a test for that.

@AviRaboah AviRaboah force-pushed the mysql-identifiers-beginning-with-digits branch from ef46ee4 to 7a68ff4 Compare April 24, 2023 21:00
@AviRaboah
Copy link
Contributor Author

AviRaboah commented Apr 24, 2023 •
edited
Loading

Hi @alamb,
The test was added :)

@AviRaboah AviRaboah requested review from alamb and ankrgyl April 24, 2023 21:03
alamb
alamb reviewed Apr 26, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AviRaboah and @ankrgyl

tests/sqlparser_mysql.rs
top: None,
projection: vec![
SelectItem::UnnamedExpr(Expr::Value(Value::Number(
"123e4".to_string(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@alamb alamb merged commit 3e92ad3 into apache:main Apr 26, 2023
serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
@iskakaushik @AviRaboah
@pawel-big-lebowski @alamb @aljazerzen @aprimadi @okue @ankane @mustafasrepo @Jefffrey @max-sixty @eitsupi @mobuchowski @berkaysynnada @ozankabak @dependabot
Merge Upstream (apache#6)
52482b3 
* Support identifiers beginning with digits in MySQL (apache#856)

* support COPY INTO in snowflake (apache#841)

Signed-off-by: Pawel Leszczynski <[email protected]>

* Add `dialect_from_str` and improve `Dialect` documentation (apache#848)

* Add `dialect_from_str` and improve `Dialect` documentation

* cleanup

* fix compilation with nostd

* Support multiple-table DELETE syntax (apache#855)

* Support `DISTINCT ON (...)` (apache#852)

* Support "DISTINCT ON (...)"

* a test

* fix the merge

* Test trailing commas (apache#859)

* test: add tests for trailing commas

* tweaks

* Add support for query source in COPY .. TO statement (apache#858)

* Add support for query source in COPY .. TO statement

* Fix compile error

* Fix logical merge conflict (apache#865)

* Fix tiny typo in custom_sql_parser.md (apache#864)

* Make Expr::Interval its own struct (apache#872)

* Make Expr::Interval its own struct

* Add test interval display

* Fix cargo fmt

* Include license file in published crate (apache#871)

* Add support for multiple expressions, order by in aggregations (apache#879)

* Add support for multiple expressions, order by in aggregations

* Fix formatting errors

* Resolve linter errors

* Add parse_multipart_identifier function to parser (apache#860)

* Add parse_multipart_identifier function to parser

* Update doc for parse_multipart_identifier

* Fix conflict

* feat: Add custom operator (apache#868)

* feat: Add custom operator

From apache#863

- It doesn't parse anything — I'm not sure how to parse ` SELECT 'a' REGEXP '^[a-d]';` with `REGEXP` as the operator... (but fine for my narrow purpose)
- If we need tests, where would I add them?

* Update src/ast/operator.rs

---------

Co-authored-by: Andrew Lamb <[email protected]>

* feat: Support MySQL's `DIV` operator (apache#876)

* feat: MySQL's DIV operator

* fix: do not use `_` prefix for used variable

---------

Co-authored-by: Andrew Lamb <[email protected]>

* truncate: table as optional keyword (apache#883)

Signed-off-by: Maciej Obuchowski <[email protected]>

* feat: add DuckDB dialect (apache#878)

* feat: add DuckDB dialect

* formatting

* fix conflict

* support // in GenericDialect

* add DucDbDialect to all_dialects

* add comment from suggestion

Co-authored-by: Andrew Lamb <[email protected]>

* fix: support // in GenericDialect

---------

Co-authored-by: Andrew Lamb <[email protected]>

* Add support for first, last aggregate function parsing (apache#882)

* Add order by parsing to functions

* Fix doc error

* minor changes

* Named window frames (apache#881)

* after over clause, named window can be parsed with window ... as after having clause

* Lint errors are fixed

* Support for multiple windows

* fix lint errors

* simplifications

* rename function

* Rewrite named window search in functional style

* Test added and some minor changes

* Minor changes on tests and namings, and semantic check is removed

---------

Co-authored-by: Mustafa Akur <[email protected]>
Co-authored-by: Mehmet Ozan Kabak <[email protected]>

* Fix merge conflict (apache#885)

* Update CHANGELOG for `0.34.0` release (apache#884)

* chore: Release sqlparser version 0.34.0

* Update criterion requirement from 0.4 to 0.5 in /sqlparser_bench (apache#890)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: Pawel Leszczynski <[email protected]>
Signed-off-by: Maciej Obuchowski <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: AviRaboah <[email protected]>
Co-authored-by: pawel.leszczynski <[email protected]>
Co-authored-by: Andrew Lamb <[email protected]>
Co-authored-by: Aljaž Mur Eržen <[email protected]>
Co-authored-by: Armin Primadi <[email protected]>
Co-authored-by: Okue <[email protected]>
Co-authored-by: Andrew Kane <[email protected]>
Co-authored-by: Mustafa Akur <[email protected]>
Co-authored-by: Jeffrey <[email protected]>
Co-authored-by: Maximilian Roos <[email protected]>
Co-authored-by: eitsupi <[email protected]>
Co-authored-by: Maciej Obuchowski <[email protected]>
Co-authored-by: Berkay Şahin <[email protected]>
Co-authored-by: Mustafa Akur <[email protected]>
Co-authored-by: Mehmet Ozan Kabak <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@romanb romanb mentioned this pull request Apr 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@ankrgyl ankrgyl Awaiting requested review from ankrgyl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect parsing literals that consisting of digits and letters, beginning with digits
4 participants
@AviRaboah @coveralls @alamb @ankrgyl