Skip to content

support IF EXISTS in COMMENT statements #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2023
Merged

support IF EXISTS in COMMENT statements #831

merged 2 commits into from
Mar 9, 2023

Conversation

pawel-big-lebowski
Copy link
Contributor

SqlParser does already support COMMENT statements which were implemented within a postgres dialect.
Comment statements are also supported within Snowflake (see docs) with an optional IF EXISTS.

This PR allows clause IF EXISTS within currently supported COMMENT statements.

@coveralls
Copy link

coveralls commented Mar 8, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4371933969

  • 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 86.132%
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 1 78.15%
Totals Coverage Status
Change from base Build 4354012682: 0.01%
Covered Lines: 13496
Relevant Lines: 15669
💛 - Coveralls

@pawel-big-lebowski pawel-big-lebowski force-pushed the snowflake/comment-if-exists branch from 2381d4d to f53b854 Compare March 8, 2023 09:10
@pawel-big-lebowski pawel-big-lebowski mentioned this pull request Mar 8, 2023
Closed
ankrgyl
ankrgyl approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@ankrgyl ankrgyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM. @alamb I think you're up next

alamb
alamb approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pawel-big-lebowski and @ankrgyl !

@pawel-big-lebowski @alamb
Update src/ast/mod.rs
426b8b4 
Co-authored-by: Andrew Lamb <[email protected]>
@alamb
Copy link
Contributor

alamb commented Mar 9, 2023

Thanks again! I appreciate the contributions

@alamb alamb merged commit 4ff3aeb into apache:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@ankrgyl ankrgyl ankrgyl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pawel-big-lebowski @coveralls @alamb @ankrgyl