Skip to content

Fix table alias parsing regression in 0.31.0 by backing out redshift column definition list #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Mar 6, 2023

Closes #826

This fixes a table alias parsing regression by reverting the change from #769 by @mskrzypkows and adding a regression test to protect against regressions in the future.

I will leave some additional notes on #769 about the cause

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4344670584

  • 18 of 18 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 86.097%

Files with Coverage Reduction New Missed Lines %
src/ast/query.rs 1 85.71%
Totals Coverage Status
Change from base Build 4315671296: -0.07%
Covered Lines: 13451
Relevant Lines: 15623

💛 - Coveralls

@alamb alamb changed the title Fix table alias parsing regression Fix table alias parsing regression in 0.31.0 by backing out redshift column definition list Mar 6, 2023
@alamb
Copy link
Contributor Author

alamb commented Mar 6, 2023

cc @ankrgyl and @mskrzypkows I wonder if you have some time to review this PR

Copy link
Contributor

@mskrzypkows mskrzypkows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have a better solution to this problem, so it's even better that it's reverted :-)

@ankrgyl
Copy link
Contributor

ankrgyl commented Mar 6, 2023

the regression test lgtm

@alamb alamb merged commit 7f4c913 into apache:main Mar 6, 2023
@alamb
Copy link
Contributor Author

alamb commented Mar 6, 2023

Thanks for the quick turnaround @ankrgyl and @mskrzypkows

@alamb alamb deleted the alamb/table_alias branch March 6, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression parsing table aliases in 0.31.0
4 participants