-
Notifications
You must be signed in to change notification settings - Fork 605
feat: Support PostgreSQL exponentiation. #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 4312856330
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AugustoFKL @alamb this change looks pretty good to me minus the couple small comments I left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @michael-2956 -- I agree with @ankrgyl 's comments. After they are done I think this PR is ready to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michael-2956
As of current version,
SELECT 3 ^ 4
in the PostgreSQL dialect reads as BinaryOperator::BitwiseXor, while it should read as the exponentiation operation. I added BinaryOperator::PGExp for that purpose and completed all the tests in this pull request.