feat: SELECT * REPLACE <Expr> AS <Identifier> for bigquery

[togami2864]

Support: https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax#select_replace

[coveralls]

Pull Request Test Coverage Report for Build 4306895174

• 53 of 57 (92.98%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.03%) to 86.172%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/ast/query.rs	9	10	90.0%
src/parser.rs	20	23	86.96%

Totals
Change from base Build 4216963554:	0.03%
Covered Lines:	13454
Relevant Lines:	15613

---

💛 - Coveralls

[AugustoFKL]

I'll review in a few hours, really sorry for the delay @togami2864. You're on fire the last weeks hehe

[AugustoFKL]

Two questions about this structure.

1. Why don't you have an enum with two fields, an expression (the field) and another with an identifier?
2. Any reason why you put the AS as mandatory? BigQuery has it as non-mandatory, but this syntax you displayed here says otherwise.

If you have a select item, the user will have to validate that the select item is not an expression or wildcard, which isn't excellent as we are such that it isn't.

• You'll have to validate the column name expression, as it MUST be an identifier.

[togami2864]

1. That make sense. It's true that having a select item needs additional validation. I'll modify the implementation.
2. I think AS is required in SELECT * Replace statement. This is the special case.
   https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax#select_replace

[AugustoFKL]

@togami2864 check the syntax structure for the select statement: https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax?hl=pt-br#select_list

select_all:
    [ expression. ]*
    [ EXCEPT ( column_name [, ...] ) ]
    [ REPLACE ( expression [ AS ] column_name [, ...] ) ]

AS is optional between the expression and its column, if I understood it correctly.

[togami2864]

Sorry, my bad. Required element is expr and column_name.

[alamb]

It looks to me like this PR has some feedback that needs implementing, so marking it as draft. Please mark it as ready for review when it is next ready.

[alamb]

LGTM -- thank you @togami2864

[ankrgyl]

(CC @alamb ) I noticed a small typo in this change while rebasing my code: the field is named colum_name instead of column_name in ReplaceSelectElement.

@alamb would it be appropriate to patch and fix this before a bunch of folks upgrade to the new release, or leave it as is?

[alamb]

@alamb would it be appropriate to patch and fix this before a bunch of folks upgrade to the new release, or leave it as is?

If someone wants to fix it up that would be great. I am would be happy to make another quick follow on release.

[togami2864]

I made #822 to followup.