Skip to content

Add User to README #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Add User to README #787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ $ cargo run --features json_example --example cli FILENAME.sql [--dialectname]
## Users

This parser is currently being used by the [DataFusion] query engine,
[LocustDB], [Ballista] and [GlueSQL].
[LocustDB], [Ballista], [GlueSQL], and [Opteryx].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joocer thanks!

@alamb I don't think there are any standards around projects that use others, so I'm not sure if that's ok.

Anyway, maybe this session could be renamed to 'Acknowledgements'? Users seems a bit weird IMO

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AugustoFKL I don't think "Acknowledgements" is quite right as we are not really acknowledging assistance from other projects.

The point of this section, as I understand, is basically to encourage more use of the sqlparser crate by offering evidence that other projects have found it valuable enough to use.

Perhaps we could change the heading (in a different PR) to something like 'Powered By' to follow https://arrow.apache.org/powered_by/ ?


If your project is using sqlparser-rs feel free to make a PR to add it
to this list.
Expand Down Expand Up @@ -178,6 +178,7 @@ licensed as above, without any additional terms or conditions.
[LocustDB]: https://github.com/cswinter/LocustDB
[Ballista]: https://github.com/apache/arrow-ballista
[GlueSQL]: https://github.com/gluesql/gluesql
[Opteryx]: https://github.com/mabel-dev/opteryx
[Pratt Parser]: https://tdop.github.io/
[sql-2016-grammar]: https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html
[sql-standard]: https://en.wikipedia.org/wiki/ISO/IEC_9075