Skip to content

Support for newer versions of cargo-release #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2022
Merged

Support for newer versions of cargo-release #660

merged 1 commit into from
Oct 7, 2022

Conversation

AugustoFKL
Copy link
Contributor

Replacing old-dated flag (1) to be able to support newer versions of cargo-publish.

[1] : https://github.com/crate-ci/cargo-release/releases/tag/v0.19.0
Resolves: #596 (@andygrove)

@AugustoFKL
Replacing 'disable-publish=true' flag by 'public=false', to allow com…
672fb3a 
…patibility with recent cargo-release versions
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3201169596

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.663%
Totals Coverage Status
Change from base Build 3199854514: 0.0%
Covered Lines: 10319
Relevant Lines: 12046
💛 - Coveralls

alamb
alamb approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- I'll try it out next time I make a release ;)

@alamb alamb merged commit 6392a21 into apache:main Oct 7, 2022
@alamb
Copy link
Contributor

alamb commented Oct 7, 2022

Thanks @AugustoFKL

@alamb
Copy link
Contributor

alamb commented Oct 19, 2022

Update here -- when I released 0.26.0 everything worked well!

cargo release minor --push-remote upstream
[2022-10-19T21:36:53Z INFO  cargo_release] Update sqlparser to version 0.26.0
[2022-10-19T21:36:53Z INFO  cargo_release] Pushing v0.26.0 to upstream
[2022-10-19T21:36:53Z INFO  cargo_release] Pushing HEAD to upstream
[2022-10-19T21:36:53Z WARN  cargo_release] Ran a `dry-run`, re-run with `--execute` if all looked good.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support newer versions of cargo-release
3 participants
@AugustoFKL @coveralls @alamb