-
Notifications
You must be signed in to change notification settings - Fork 612
Parse LIKE patterns as Expr not Value #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ayushdg could you take a look? |
Pull Request Test Coverage Report for Build 2877509204Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching the regressions and updating like patterns to accept expr's
I'm going to go ahead and merge this based on the approval from @ayushdg since this is blocking a number of issues in DataFusion. |
Thanks @andygrove |
Can drop this after rebase on commit eb7f1b0 "Parse LIKE patterns as Expr not Value (apache#579)", first released in 0.21.0
Can drop this after rebase on commit eb7f1b0 "Parse LIKE patterns as Expr not Value (apache#579)", first released in 0.21.0
Closes #578
This fixes a regression in parsing LIKE patterns that was introduced in #569.
I also made some small improvements in the precedence code by extracting more hard-coded values into consts so we can more easily see the relationship between different operators. I added a link to the Postgres precedence docs for reference as well.