Distinguish between SELECT * FROM foo and SELECT * FROM foo()
#506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
May 25, 2022
| @@ -337,7 +337,11 @@ pub enum TableFactor { | |||
| /// Arguments of a table-valued function, as supported by Postgres | |||
| /// and MSSQL. Note that deprecated MSSQL `FROM foo (NOLOCK)` syntax | |||
| /// will also be parsed as `args`. | |||
| args: Vec<FunctionArg>, | |||
| /// | |||
| /// This field's value is `Some(v)`, where `v` is a (possibly empty) | |||
Pull Request Test Coverage Report for Build 2376533905
💛 - Coveralls |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405. As stated in that issue,
To fix it, I reintroduced the
Optionaround the vector of arguments, which was removed in 5652b46 even though it wasn't actually redundant. I also added a test which ensures thatSELECT * FROM fn()is not modified after a serialization round-trip, and I added a brief explanation of the different meanings ofNoneandSome(includingSome(vec![])) to the documentation.