Support OVER clause for window/analytic functions and qualified function names #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this changes SQLFunction anyway, changed its `id` field to `name`, as we don't seem to use "id" to mean "name" anywhere else.
...e.g. `db.schema.func()`
(This produces more natural JSON representation when serializing AST with serde.)
Pull Request Test Coverage Report for Build 153
💛 - Coveralls |
nickolay
force-pushed
the
window-functions
branch
from
056877b to
218e155
Compare
nickolay
force-pushed
the
window-functions
branch
from
218e155 to
9a244e0
Compare
andygrove
approved these changes
Apr 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements most of what the spec calls
<in-line window specification>, sans references toWINDOWs defined elsewhere and theEXCLUDEclause.Tangentially related is the change of SQLFunction's
id: SQLIdenttoname: SQLObjectNameand the addition of support for schema-qualified function names (db.schema.func).Unrelated, but didn't seem to deserve its own PR is a change to make
ExpressionWithAliasuse named fields (I don't know why I made it a tuple in the first place..)