Skip to content

Support SELECT DISTINCT, and a few minor tweaks #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 20, 2019

Conversation

nickolay
Copy link
Contributor

The grammar describes this as:

    <query specification> ::=
        SELECT [ <set quantifier> ] <select list> <table expression>

    <set quantifier> ::=
        DISTINCT
      | ALL

I've chosen not to add ALL, as it's equivalent to omitting the quantifier and I have not ever seen it used in practice (I'm also afraid that some dialects might allow ALL as a column name).

(I've also included some minor unrelated changes as separate commits in this PR.)

@coveralls
Copy link

coveralls commented Apr 20, 2019

Pull Request Test Coverage Report for Build 145

  • 21 of 25 (84.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 85.31%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sqlparser.rs 6 7 85.71%
src/sqlast/sqltype.rs 0 3 0.0%
Totals Coverage Status
Change from base Build 143: 0.09%
Covered Lines: 2625
Relevant Lines: 3077

💛 - Coveralls

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andygrove andygrove merged commit 6ebd5dd into apache:master Apr 20, 2019
@nickolay
Copy link
Contributor Author

Thanks for the quick review!

@nickolay nickolay deleted the select-distinct branch April 20, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants