Skip to content

Support CHARSET and ENGINE clauses on CREATE TABLE for mysql #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 8, 2022

Conversation

antialize
Copy link
Contributor

That adds support for various features missing to parse a specific phpmyadmin database export.

@antialize antialize force-pushed the mysql_improvements branch 2 times, most recently from 6d7e37e to 40fa586 Compare December 27, 2021 14:55
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @antialize

@@ -155,6 +155,93 @@ fn parse_create_table_auto_increment() {
}
}

#[test]
fn parse_create_table_set_enum() {
let sql = "CREATE TABLE foo (bar SET('a', 'b'), baz ENUM('a', 'b'))";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Database changed
mysql> CREATE TABLE foo (bar SET('a', 'b'), baz ENUM('a', 'b'));
Query OK, 0 rows affected (0.01 sec)

@alamb alamb changed the title Mysql improvements Support CHARSET and ENGINE clauses on CREATE TABLE for mysql Feb 8, 2022
@alamb alamb merged commit e495969 into apache:main Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants