-
Notifications
You must be signed in to change notification settings - Fork 612
Fix #369 - Add Support in Date/Time keywords #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double checked that both mysql and postgres indeed do treat these specially:
👍
Thanks @yuval-illumex
mysql> select current_timestamp;
+---------------------+
| current_timestamp |
+---------------------+
| 2021-12-17 12:30:40 |
+---------------------+
1 row in set (0.00 sec)
mysql> select current_time;
+--------------+
| current_time |
+--------------+
| 12:30:45 |
+--------------+
1 row in set (0.00 sec)
mysql> select current_date;
+--------------+
| current_date |
+--------------+
| 2021-12-17 |
+--------------+
1 row in set (0.00 sec)
mysql> ^DBye
(arrow_dev) alamb@MacBook-Pro-2:~/Software/arrow-datafusion$ psql
psql (14.1)
Type "help" for help.
alamb=# select current_timestamp;
current_timestamp
-------------------------------
2021-12-17 12:30:59.547784-05
(1 row)
alamb=# select current_time;
current_time
--------------------
12:31:02.464701-05
(1 row)
alamb=# select current_date;
current_date
--------------
2021-12-17
(1 row)
Pull Request Test Coverage Report for Build 1616040264Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- thanks @yuval-illumex
These appear to have been included in #391 so closing this one down |
Fix #369
Add Support for:
CURRENT_TIMESTAMP
CURRENT_DATE
CURRENT_TIME
Which are function without args.